From owner-dev-commits-src-all@freebsd.org Wed Sep 8 16:01:58 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 204D567DA3F; Wed, 8 Sep 2021 16:01:58 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4H4Rj20PX7z3sJy; Wed, 8 Sep 2021 16:01:58 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 7AB3CBB3B; Wed, 8 Sep 2021 16:01:57 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: git: a8b89dff6ac0 - main - Disable acpi_timer_test by default To: Colin Percival , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202109080132.1881WXPv069848@gitrepo.freebsd.org> From: John Baldwin Message-ID: Date: Wed, 8 Sep 2021 09:01:56 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <202109080132.1881WXPv069848@gitrepo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2021 16:01:58 -0000 On 9/7/21 6:32 PM, Colin Percival wrote: > The branch main has been updated by cperciva: > > URL: https://cgit.FreeBSD.org/src/commit/?id=a8b89dff6ac026e60983824889d3666842ff409b > > commit a8b89dff6ac026e60983824889d3666842ff409b > Author: Colin Percival > AuthorDate: 2021-09-07 23:59:45 +0000 > Commit: Colin Percival > CommitDate: 2021-09-08 01:31:55 +0000 > > Disable acpi_timer_test by default > > This disables testing the ACPI timer by default, forcing the use of > ACPI-fast rather than ACPI-safe. The broken-ACPI-timers workaround > can be re-enabled by setting the hw.acpi.timer_test_enabled=1 tunable. > > This speeds up the FreeBSD boot process by 140 ms on an EC2 c5.xlarge > instance. > > This change will not be MFCed. > > Assuming no problems are reported, acpi_timer_test, the associated > tunable, and the ACPI-safe timecounter should be removed in FreeBSD 15. > > Relnotes: The ACPI-safe timer is disabled in favour of ACPI-fast; > if timekeeping issues are observed, please test with > hw.acpi.timer_test_enabled=1 in loader.conf and report > if that fixes the problem. Perhaps it should default to '1' for i386 and '0' otherwise? The relevant chipsets were 32-bit only, so this would be a simple way to skip the test for modern hardware, and you could probably MFC that safely. -- John Baldwin