From owner-freebsd-ports-bugs@freebsd.org Thu Nov 29 10:34:39 2018 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 66AA4115B6FB for ; Thu, 29 Nov 2018 10:34:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id F27EE82971 for ; Thu, 29 Nov 2018 10:34:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id B5D5E115B6F7; Thu, 29 Nov 2018 10:34:38 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 932BE115B6F5 for ; Thu, 29 Nov 2018 10:34:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2C9A582970 for ; Thu, 29 Nov 2018 10:34:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 2F5A81234 for ; Thu, 29 Nov 2018 10:34:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wATAYbll007549 for ; Thu, 29 Nov 2018 10:34:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wATAYbVn007548 for ports-bugs@FreeBSD.org; Thu, 29 Nov 2018 10:34:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 212097] [NEW PORT] www/apt-cacher-ng: Caching proxy for software distribution sites port (includes FreeBSD customization) Date: Thu, 29 Nov 2018 10:34:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, needs-patch, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: tobik@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tobik@freebsd.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Rspamd-Queue-Id: F27EE82971 X-Spamd-Result: default: False [1.69 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_SPAM_LONG(0.57)[0.567,0]; NEURAL_SPAM_SHORT(0.45)[0.451,0]; NEURAL_SPAM_MEDIUM(0.68)[0.676,0]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 10:34:39 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D212097 Tobias Kortkamp changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|ports-bugs@FreeBSD.org |tobik@freebsd.org --- Comment #7 from Tobias Kortkamp --- ould you order the variables according to [1]?=20 XThis is a port of apt-cacher-ng, a caching http/s proxy specialized in Never start pkg-descr with "This is a port". How about starting with "apt-cacher-ng is a caching ..." instead? There are also some typos in pkg-descr. XMore details are on the original projects web page. I think this sentence is superfluous and could be dropped. It's pretty much why pkg-descr always ends with WWW. XOPTIONS_DEFAULT=3D SSL DOCS DOCS is always enabled by default, so it doesn't need to be here. X#SSL_BUILD_DEPENDS=3D pkg-config:devel/pkgconf X#SSL_BUILD_DEPENDS=3D pkg-config:devel/pkgconf openssl:security/openssl X#SSL_LIB_DEPENDS=3D libcrypto.so:security/openssl Please remove all the commented out variables. Especially these very wrong bits. XSSL_DESC=3D Include SSL support to allow proxying https sites. Remove the dot at the end. XFUSE_DESC=3D Include FUSE support. FUSE already has a better common description. What does the option do in the context of the port (maybe mention acngfs)? XDISTNAME=3D ${PORTNAME}_${PORTVERSION}.orig You can eliminate setting WRKSRC below if you use DISTFILES=3D ${PORTNAME}_${PORTVERSION}.orig${EXTRACT_SUFX} instead here. Xpost-stage: Use post-install X ${INSTALL_MAN} ${WRKSRC}/COPYING ${STAGEDIR}${DOCSDIR} X ${INSTALL_MAN} ${WRKSRC}/ChangeLog ${STAGEDIR}${DOCSDIR} X ${INSTALL_MAN} ${WRKSRC}/TODO ${STAGEDIR}${DOCSDIR} Use INSTALL_DATA to install documentation. COPYING is already installed via LICENSE_FILE. No need to install it twice. Does the ChangeLog and TODO really contain useful information for users? X ${INSTALL_MAN} ${WRKDIR}/Readme.FreeBSD ${STAGEDIR}${DOCSDIR} I think this should be a pkg-message instead, so that users see it after installation. [1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html --=20 You are receiving this mail because: You are the assignee for the bug.=