From owner-svn-src-head@freebsd.org Sat Nov 19 05:38:09 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6151FC497DA for ; Sat, 19 Nov 2016 05:38:09 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: from asp.reflexion.net (outbound-mail-210-32.reflexion.net [208.70.210.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ED94D994 for ; Sat, 19 Nov 2016 05:38:08 +0000 (UTC) (envelope-from markmi@dsl-only.net) Received: (qmail 13075 invoked from network); 19 Nov 2016 05:37:46 -0000 Received: from unknown (HELO mail-cs-01.app.dca.reflexion.local) (10.81.19.1) by 0 (rfx-qmail) with SMTP; 19 Nov 2016 05:37:46 -0000 Received: by mail-cs-01.app.dca.reflexion.local (Reflexion email security v8.20.0) with SMTP; Sat, 19 Nov 2016 00:38:11 -0500 (EST) Received: (qmail 32709 invoked from network); 19 Nov 2016 05:38:11 -0000 Received: from unknown (HELO iron2.pdx.net) (69.64.224.71) by 0 (rfx-qmail) with (AES256-SHA encrypted) SMTP; 19 Nov 2016 05:38:11 -0000 Received: from [192.168.1.106] (c-76-115-7-162.hsd1.or.comcast.net [76.115.7.162]) by iron2.pdx.net (Postfix) with ESMTPSA id BEAFEEC91A9; Fri, 18 Nov 2016 21:38:00 -0800 (PST) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 10.1 \(3251\)) Subject: Re: svn commit: r308691 - in head/sys: cddl/compat/opensolaris/sys cddl/contrib/opensolaris/uts/common/fs/zfs fs/tmpfs kern vm Message-Id: <147CB9E9-6515-486E-B0D2-1DB096C834FB@dsl-only.net> Date: Fri, 18 Nov 2016 21:37:58 -0800 To: svn-src-head@freebsd.org, alc@rice.edu X-Mailer: Apple Mail (2.3251) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Nov 2016 05:38:09 -0000 Alan Cox alc at rice.edu wrote on Wed Nov 16 17:54:03 UTC 2016 : > This change amounted to dead code removal, so I'm not sure how it = could > have an effect. There were only a couple places where the changes = were > other than mechanical in nature. Also, that the number of cores = matters > is no less puzzling. But bugzilla 214629 reports a fix that is not checked in yet: Andriy Gapon in Comment 1 notes for = /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c = around line 430 (as listed in the description): > Now that 'else if (pp =3D=3D NULL)' block has been removed (and we no = longer fabricate a cached page), the code should look like: > ... > else if (pp !=3D NULL) { > ASSERT(!pp->valid); > pp =3D NULL; > } Alan Cox then agrees (Comment 2) --and Shawn Webb reports trying the = change fixed the issue for him (Comment 3). So once the fix is checked in and put to use this issue will likely go = away. =3D=3D=3D Mark Millard markmi at dsl-only.net