Date: Wed, 17 Jun 2020 10:55:58 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Kyle Evans <kevans@freebsd.org>, Mateusz Guzik <mjguzik@gmail.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r361967 - head/sys/kern Message-ID: <0101b152-e3a6-61af-3748-04e73b631f51@FreeBSD.org> In-Reply-To: <CACNAnaG8jDT8svqG2NRrqEU0u4GirHSbvstd2hyvVouDZPHRtA@mail.gmail.com> References: <202006091517.059FHNS9050196@repo.freebsd.org> <CACNAnaHLmwemMtHLNA5QwCbFxnEkVc7D-kw1TCqNLh3v5QMJQw@mail.gmail.com> <CAGudoHFUpFb6wBc=wxzwGJrOzER-xd6gU6pW6mLJLi6%2BvgYbqA@mail.gmail.com> <CACNAnaG8jDT8svqG2NRrqEU0u4GirHSbvstd2hyvVouDZPHRtA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6/17/20 9:39 AM, Kyle Evans wrote: > On Wed, Jun 17, 2020 at 10:21 AM Mateusz Guzik <mjguzik@gmail.com> wrote: >> >> pho@ reported triggering one of the asserts: >> https://people.freebsd.org/~pho/stress/log/mjguzik028.txt >> >> I did not have the time to properly investigate this yet and this does >> not reproduce for me. >> > > Ah, this is good to know that he's reproduced it. There's only so many > places that we touch these. I can't quite envision how, but the only > scenario this would seem to be possible in is doenterpgrp() -> > fixjobc(p, p->p_grp, 0) -> adjusts some child with a different process > group without actually changing it, orphans the group, then we manage > to finalize killjobc() on a freshly-orphaned process, which hasn't had > its p_pgrp nullified. > > I haven't yet traced it through completely enough to determine if > there's any way that can even happen. I reproduced it three times yesterday in a head VM by exiting GDB while it was attached to a live process (which kills the process), something like: gdb /bin/ls start ^D Should be enough to reproduce. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0101b152-e3a6-61af-3748-04e73b631f51>