Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 16 Jan 2018 10:19:07 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-pf@FreeBSD.org
Subject:   [Bug 209475] pf didn't check if enough free RAM for net.pf.states_hashsize
Message-ID:  <bug-209475-17777-fXUO6yJ6z6@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-209475-17777@https.bugs.freebsd.org/bugzilla/>
References:  <bug-209475-17777@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209475

--- Comment #14 from fehmi noyan isi <fnoyanisi@yahoo.com> ---
(In reply to Kristof Provost from comment #13)

>> I do see why, because it's non-trivial to cope with allocation failures in that part of the code. It gets called from a VNET_SYSINIT(), so it doesn't have a reasonable way of aborting the initialisation.

So, does this come down to supplying a default value and re-attempting malloc()
again?

>> As an aside, the allocations should probably be changed to use mallocarray() too
Yes, that might help to avoid this bug, but I do not think FreeBSD has
mallocarray()?

-- 
You are receiving this mail because:
You are the assignee for the bug.


Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-209475-17777-fXUO6yJ6z6>