From owner-svn-src-all@freebsd.org Fri Jun 9 15:48:13 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9FE4CBF7EE2; Fri, 9 Jun 2017 15:48:13 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 6AAD47211A; Fri, 9 Jun 2017 15:48:11 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA17477; Fri, 09 Jun 2017 18:42:05 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1dJM33-0009dq-Ju; Fri, 09 Jun 2017 18:42:05 +0300 Subject: Re: svn commit: r317591 - head/sys/dev/drm2/radeon From: Andriy Gapon To: Takahashi Yoshihiro , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <201704290947.v3T9lF0r075921@repo.freebsd.org> <03e500d5-76b1-fd38-04c6-90d85a2ddfa8@FreeBSD.org> Message-ID: <086f41db-c2a1-5367-6acb-59df190a43db@FreeBSD.org> Date: Fri, 9 Jun 2017 18:40:44 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <03e500d5-76b1-fd38-04c6-90d85a2ddfa8@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jun 2017 15:48:13 -0000 [ping] On 31/05/2017 08:22, Andriy Gapon wrote: > On 29/04/2017 12:47, Takahashi Yoshihiro wrote: >> Author: nyan >> Date: Sat Apr 29 09:47:15 2017 >> New Revision: 317591 >> URL: https://svnweb.freebsd.org/changeset/base/317591 >> >> Log: >> Add TUNABLE_INT to radeonkms driver parameters. >> They are required by PowerMac G5 DP. >> >> PR: 217852 >> Submitted by: Hiroo Ono >> MFC after: 1 week > > I think that this solution that I had in my private tree is a little bit more > powerful: > https://people.freebsd.org/~avg/radeon_drv-knobs.diff > > The advantage is that it is less intrusive and also provides read-only sysctl in > addition to the tunables. > Also, hw.drm.radeon seems like a better place for the knobs than just drm.radeon. > > Do you mind if I commit this? > >> Modified: >> head/sys/dev/drm2/radeon/radeon_drv.c >> >> Modified: head/sys/dev/drm2/radeon/radeon_drv.c >> ============================================================================== >> --- head/sys/dev/drm2/radeon/radeon_drv.c Sat Apr 29 09:26:30 2017 (r317590) >> +++ head/sys/dev/drm2/radeon/radeon_drv.c Sat Apr 29 09:47:15 2017 (r317591) >> @@ -127,54 +127,71 @@ int radeon_pcie_gen2 = -1; >> int radeon_msi = -1; >> int radeon_lockup_timeout = 10000; >> >> +TUNABLE_INT("drm.radeon.no_wb", &radeon_no_wb); >> MODULE_PARM_DESC(no_wb, "Disable AGP writeback for scratch registers"); >> module_param_named(no_wb, radeon_no_wb, int, 0444); >> >> +TUNABLE_INT("drm.radeon.modeset", &radeon_modeset); >> MODULE_PARM_DESC(modeset, "Disable/Enable modesetting"); >> module_param_named(modeset, radeon_modeset, int, 0400); >> >> +TUNABLE_INT("drm.radeon.dynclks", &radeon_dynclks); >> MODULE_PARM_DESC(dynclks, "Disable/Enable dynamic clocks"); >> module_param_named(dynclks, radeon_dynclks, int, 0444); >> >> +TUNABLE_INT("drm.radeon.r4xx_atom", &radeon_r4xx_atom); >> MODULE_PARM_DESC(r4xx_atom, "Enable ATOMBIOS modesetting for R4xx"); >> module_param_named(r4xx_atom, radeon_r4xx_atom, int, 0444); >> >> +TUNABLE_INT("drm.radeon.vramlimit", &radeon_vram_limit); >> MODULE_PARM_DESC(vramlimit, "Restrict VRAM for testing"); >> module_param_named(vramlimit, radeon_vram_limit, int, 0600); >> >> +TUNABLE_INT("drm.radeon.agpmode", &radeon_agpmode); >> MODULE_PARM_DESC(agpmode, "AGP Mode (-1 == PCI)"); >> module_param_named(agpmode, radeon_agpmode, int, 0444); >> >> +TUNABLE_INT("drm.radeon.gartsize", &radeon_gart_size); >> MODULE_PARM_DESC(gartsize, "Size of PCIE/IGP gart to setup in megabytes (32, 64, etc)"); >> module_param_named(gartsize, radeon_gart_size, int, 0600); >> >> +TUNABLE_INT("drm.radeon.benchmark", &radeon_benchmarking); >> MODULE_PARM_DESC(benchmark, "Run benchmark"); >> module_param_named(benchmark, radeon_benchmarking, int, 0444); >> >> +TUNABLE_INT("drm.radeon.test", &radeon_testing); >> MODULE_PARM_DESC(test, "Run tests"); >> module_param_named(test, radeon_testing, int, 0444); >> >> +TUNABLE_INT("drm.radeon.connector_table", &radeon_connector_table); >> MODULE_PARM_DESC(connector_table, "Force connector table"); >> module_param_named(connector_table, radeon_connector_table, int, 0444); >> >> +TUNABLE_INT("drm.radeon.tv", &radeon_tv); >> MODULE_PARM_DESC(tv, "TV enable (0 = disable)"); >> module_param_named(tv, radeon_tv, int, 0444); >> >> +TUNABLE_INT("drm.radeon.audio", &radeon_audio); >> MODULE_PARM_DESC(audio, "Audio enable (1 = enable)"); >> module_param_named(audio, radeon_audio, int, 0444); >> >> +TUNABLE_INT("drm.radeon.disp_priority", &radeon_disp_priority); >> MODULE_PARM_DESC(disp_priority, "Display Priority (0 = auto, 1 = normal, 2 = high)"); >> module_param_named(disp_priority, radeon_disp_priority, int, 0444); >> >> +TUNABLE_INT("drm.radeon.hw_i2c", &radeon_hw_i2c); >> MODULE_PARM_DESC(hw_i2c, "hw i2c engine enable (0 = disable)"); >> module_param_named(hw_i2c, radeon_hw_i2c, int, 0444); >> >> +TUNABLE_INT("drm.radeon.pcie_gen2", &radeon_pcie_gen2); >> MODULE_PARM_DESC(pcie_gen2, "PCIE Gen2 mode (-1 = auto, 0 = disable, 1 = enable)"); >> module_param_named(pcie_gen2, radeon_pcie_gen2, int, 0444); >> >> +TUNABLE_INT("drm.radeon.msi", &radeon_msi); >> MODULE_PARM_DESC(msi, "MSI support (1 = enable, 0 = disable, -1 = auto)"); >> module_param_named(msi, radeon_msi, int, 0444); >> >> +TUNABLE_INT("drm.radeon.lockup_timeout", &radeon_lockup_timeout); >> MODULE_PARM_DESC(lockup_timeout, "GPU lockup timeout in ms (defaul 10000 = 10 seconds, 0 = disable)"); >> module_param_named(lockup_timeout, radeon_lockup_timeout, int, 0444); >> >> > > -- Andriy Gapon