From owner-freebsd-ports@freebsd.org Wed Mar 23 11:27:31 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 65C6DADACDF for ; Wed, 23 Mar 2016 11:27:31 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 4DEC711D3 for ; Wed, 23 Mar 2016 11:27:31 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 494BFADACDE; Wed, 23 Mar 2016 11:27:31 +0000 (UTC) Delivered-To: ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 48ED4ADACDD for ; Wed, 23 Mar 2016 11:27:31 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id DFB2B11D2; Wed, 23 Mar 2016 11:27:30 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 4F3F9BDC56; Wed, 23 Mar 2016 12:27:28 +0100 (CET) Received: from gw.in.absolight.net (gw-ecl.in.absolight.net [79.143.241.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gw.in.absolight.net", Issuer "CA Cert Signing Authority" (not verified)) by prod2.absolight.net (Postfix) with ESMTPSA id 1525CBDC1F; Wed, 23 Mar 2016 12:27:28 +0100 (CET) Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239]) by gw.in.absolight.net (Postfix) with ESMTP id C6F146124; Wed, 23 Mar 2016 12:27:26 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by ogg.in.absolight.net (Postfix) with ESMTP id 6948721F358E; Wed, 23 Mar 2016 12:27:25 +0100 (CET) Date: Wed, 23 Mar 2016 12:27:23 +0100 From: Mathieu Arnold To: Don Lewis cc: ports@FreeBSD.org Subject: Re: gnome-post-install ordering Message-ID: <2F936CEC82E5BACE893F56D6@ogg.in.absolight.net> In-Reply-To: <201603212043.u2LKhhuU061228@gw.catspoiler.org> References: <201603212043.u2LKhhuU061228@gw.catspoiler.org> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="==========C028120EC9E624DE7999==========" X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2016 11:27:31 -0000 --==========C028120EC9E624DE7999========== Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline +--On 21 mars 2016 13:43:43 -0700 Don Lewis wrote: | On 21 Mar, Mathieu Arnold wrote: |> +--On 21 mars 2016 11:18:26 -0700 Don Lewis wrote: |> | gnome-post-install does several different things. I haven't looked to |> | see if all of them should be moved. Unfortunately I'm not sure that an |> | exp-run would pick up some of the more subtle breakage. |> |> Then, we just extract the INSTALL_ICONS bits into a gnome-install-icons |> target, and run it later, much later. The gnome-post-install target |> could benefit from being split up. It was not so before because |> USES=gnome is quite new, and adding stuff to the target ordering system |> was a pain. Now, it could be splitted in gnome-gconf-schemas, |> gnome-glib-schemas, gnome-installs-omf, and gnome-install-icons. It was |> on my roadmap when I rewrote the target ordering system to use numbers, |> but I decided against changing too many things at once. | | That sounds fine to me. I didn't closely look at the rest of | gnome-post-install since I was concentrating on the problem at hand. I went looking around Mk/Uses for targets not using helpers, ended up with https://reviews.freebsd.org/D5717 | I'd also like a target explicity for generating a dynamic plist that | runs after post-install. Doing it in post-install works most of the | time unless you start using post-install option helpers to install | additional files. No, dynamic plists are evil you don't check what end up in the package, and it's a mess. The only exception is ruby gems and python modules because things change too much between ruby/python versions and it can't be done another way. |> | One of my concerns is that if we start using TARGET_ORDER_OVERRIDE all |> | over the place, that will make maintaining the framework a lot more |> | difficult. |> |> There's a difference between all over the place and in a dozen ports :-) |> (it only makes it about 0.05% of the time, if I get my math right) | | Well, here are a bunch more ... these contain both INSTALLS_ICONS and | "autoplist", which I'm assuming comes from USES_GNOME=autoplist I think you mean USE_PYTHON=autoplist, but the python autoplist feature only grabs stuff in the python module directory, so not icons. -- Mathieu Arnold --==========C028120EC9E624DE7999========== Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQJ8BAEBCgBmBQJW8n2cXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IJTUP/2lK37JT3Ux2AzaLLL/MjebZ x9NyL48kG77XRn50S7g143h0dnXG7ooehxR64zGCHEnYd3G/RnssW0NByrsNI5Qk 4MQPDm9DEbzTWazkSKkwvsZgC8XDTNPqul164NhvfSWNRWE23N5GdgI+3hjDhnOA w7bUcvQfP1G+kWzr9ixukcmJRE8EhhbvUNyGpsXUkfd2OYja9navmdM5iTrp32yI 1pj+4AJQOajiDsTEAlGHaiRd8QyNg+Vryv647E/WIwmkiIUul033KxU4uk3rbNFk IbBBGJqRGGc/vfTjMXX9lggOT18YjjzaLOCY4PBm2tbAW8fLVFFX+vtK/K1Emt/q j+qkz0sRXYvmWpCu4uKqo0zEUoCKCRZrlG+1d5bhYL9XZ/aHYmKBfEF9kwTs7mXe wPrfoAYjyoYRl7veJudbjEotHYdDhaxoflEeYUcR40jaxBh+gjbYSUlBmkzx9CF0 n0NqChlseOLDh/AAUIFJ46W4TVmaEnZ7kHDFPZUc5zUo0vejO887Qwpq2qiY23y1 nXDTlp0Q25aA+U3OQnb2W4iUjyDFyE0POjzjDE4VRsUnEdyim6vgGgCMRV4b+ufq ym/MEfAjteR9zjM6xW46XlaXM463HMCUzyy0DgXdBTUXZ+MxAUVpzi3RDHZd/uNG xsA6SsQKjyVSK2lORIbt =p4E6 -----END PGP SIGNATURE----- --==========C028120EC9E624DE7999==========--