From owner-freebsd-arch Sun Mar 25 10:40:19 2001 Delivered-To: freebsd-arch@freebsd.org Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id CF78E37B71B for ; Sun, 25 Mar 2001 10:40:16 -0800 (PST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.11.1/8.11.1) with ESMTP id f2PIeE973790; Sun, 25 Mar 2001 11:40:14 -0700 (MST) (envelope-from imp@harmony.village.org) Message-Id: <200103251840.f2PIeE973790@harmony.village.org> To: Peter Pentchev Subject: Re: Building only a specified list of kernel modules Cc: arch@FreeBSD.ORG In-reply-to: Your message of "Sat, 24 Mar 2001 21:11:40 +0200." <20010324211140.C4304@ringworld.oblivion.bg> References: <20010324211140.C4304@ringworld.oblivion.bg> Date: Sun, 25 Mar 2001 11:40:14 -0700 From: Warner Losh Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG I object to this patch. It is needlessly complicated. It adds too many icky knobs to the tree, created duplicate places where you'd need lists, etc. Index: Makefile =================================================================== RCS file: /home/imp/FreeBSD/CVS/src/sys/modules/Makefile,v retrieving revision 1.171 diff -u -r1.171 Makefile --- Makefile 2001/03/09 20:10:30 1.171 +++ Makefile 2001/03/19 19:17:28 @@ -30,4 +30,8 @@ SUBDIR+=osf1 .endif +.if defined(MODULES_OVERRIDE) +SUBDIR=${MODULES_OVERRIDE} +.endif + .include Should be all that's needed. You can list all the directories you want in there, or trees of directories. No need to go and get extra fancy with this. Peter is working on a better scheme for -current and this is minimally invasive in -stable. People would just add a makeoptions MODULES_OVERRIDE="pcic sound/pcm sound/drivers/ex137x" to their kernel config files and be done with it. While this doesn't provide the NO_KMOD_xxx functionality, I don't think that's needed. People are much much more likely to compile just what they want and nothing else than they are to compile the defaults with one or two things trimmed out. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message