From owner-freebsd-net@FreeBSD.ORG Tue May 18 07:38:46 2010 Return-Path: Delivered-To: freebsd-net@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 163911065708 for ; Tue, 18 May 2010 07:38:46 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 026DB8FC29 for ; Tue, 18 May 2010 07:38:45 +0000 (UTC) Received: by elvis.mu.org (Postfix, from userid 1192) id E25DE1A3D5F; Tue, 18 May 2010 00:38:45 -0700 (PDT) Date: Tue, 18 May 2010 00:38:45 -0700 From: Alfred Perlstein To: Hiroki Sato Message-ID: <20100518073845.GC6175@elvis.mu.org> References: <20100516062211.GC6175@elvis.mu.org> <20100518.141933.111781762.hrs@allbsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100518.141933.111781762.hrs@allbsd.org> User-Agent: Mutt/1.4.2.3i Cc: freebsd-net@FreeBSD.org Subject: Re: Patch for ip6_sprintf(), please review X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 May 2010 07:38:46 -0000 * Hiroki Sato [100517 22:43] wrote: > Alfred Perlstein wrote > in <20100516062211.GC6175@elvis.mu.org>: > > al> The following patch seems appropriate to apply > al> to fix the kernel ip6_sprintf() function. > al> > al> What it is doing is ensuring that when we > al> abbreviate addresses that the longest string > al> of zeros is shortend, not the first run of > al> zeros. > (snip) > al> Diff is attached in text format. > > I think the code is correct and reasonable for commit. Ok, I will do some final checks and commit shortly. Thank you, -Alfred