From owner-freebsd-hackers@FreeBSD.ORG  Thu Jun  3 02:46:52 2004
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 450DD16A4CE; Thu,  3 Jun 2004 02:46:52 -0700 (PDT)
Received: from cell.sick.ru (cell.sick.ru [217.72.144.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D0C5143D60; Thu,  3 Jun 2004 02:46:50 -0700 (PDT)
	(envelope-from glebius@cell.sick.ru)
Received: from cell.sick.ru (glebius@localhost [127.0.0.1])
	by cell.sick.ru (8.12.9/8.12.8) with ESMTP id i539kSvw089941
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 3 Jun 2004 13:46:28 +0400 (MSD)
	(envelope-from glebius@cell.sick.ru)
Received: (from glebius@localhost)
	by cell.sick.ru (8.12.9/8.12.6/Submit) id i539kQUh089940;
	Thu, 3 Jun 2004 13:46:26 +0400 (MSD)
Date: Thu, 3 Jun 2004 13:46:26 +0400
From: Gleb Smirnoff <glebius@cell.sick.ru>
To: Sam Leffler <sam@errno.com>
Message-ID: <20040603094626.GA89838@cell.sick.ru>
References: <20040531215101.GA60299@freefall.freebsd.org>
	<20040602094940.GA80394@cell.sick.ru> <200406021056.53005.sam@errno.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <200406021056.53005.sam@errno.com>
User-Agent: Mutt/1.5.6i
X-Mailman-Approved-At: Thu, 03 Jun 2004 05:09:54 -0700
cc: freebsd-hackers@freebsd.org
cc: freebsd-current@freebsd.org
cc: Bosko Milekic <bmilekic@freebsd.org>
Subject: Re: [HEADS-UP] mbuma is in the tree
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Jun 2004 09:46:52 -0000

On Wed, Jun 02, 2004 at 10:56:52AM -0700, Sam Leffler wrote:
S> >   are you going to convert mbuf tag allocator to UMA? Now
S> > tags are allocated with malloc(). AFAIK, tags are used heavily in pf,
S> > and forthcoming ALTQ. Moving to UMA should affect their performance
S> > positively.
S> 
S> You probably meant you wanted to use a UMA zone.  m_tag's can already be 

Exactly.

What about using its own UMA zone for each m_tag consumer: pf, ALTQ, divert,
vlan? Each module allocates its zone on startup, and later a reference to
this zone is passed to m_tag_alloc().

S> allocated using this mechanism.  I did it once for vlan tags but botched it 
S> (didn't handle module references properly) so backed it. But there's no 
S> reason someone cannot redo it or convert other heavily used fixed size tags 
S> to use a zone.

Have you saved your efforts? May I look at them?

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE