Date: Tue, 28 Mar 2017 16:57:08 +0200 From: Michael Gmelin <grembo@freebsd.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r437089 - in head/devel: . hhdate hhdate/files Message-ID: <20170328165708.3feecd6a@bsd64.grem.de> In-Reply-To: <20170328142701.GA20879@FreeBSD.org> References: <201703272235.v2RMZKfx024323@repo.freebsd.org> <20170328142701.GA20879@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 28 Mar 2017 14:27:01 +0000 Alexey Dokuchaev <danfe@FreeBSD.org> wrote: > On Mon, Mar 27, 2017 at 10:35:20PM +0000, Michael Gmelin wrote: > > New Revision: 437089 > > URL: https://svnweb.freebsd.org/changeset/ports/437089 > > > > Log: > > Add hhdate 2.1.0.35, date and time library based on the C++11 (and > > beyond) <chrono> header. > > > > [...] > > +PORTVERSION= 2.1.0.35 > > +CATEGORIES= devel > > + > > +MAINTAINER= andreas.sommer87@googlemail.com > > +COMMENT= Date and time library based on the C++11 > > (and beyond) <chrono> header + > > +LICENSE= MIT > > +LICENSE_FILE= ${WRKSRC}/LICENSE.txt > > + > > +USE_GITHUB= yes > > +GH_ACCOUNT= HowardHinnant > > +GH_PROJECT= date > > +GH_TAGNAME= 3ab6510cab764c1a20926b1e8442af4c9e8a16b2 > > [ and below ] > > Bogus formatting (one extra tab after knobs), would you please fix it? These are in to align to TEST_TEST_TARGET=<tab>test, otherwise it would look like this: TEST_USES= compiler:c++11-lib TEST_TEST_TARGET=test (replaced tabs by spaces for email) Would this actually be preferred? > > > +.include <bsd.port.options.mk> > > + > > +.if ${PORT_OPTIONS:MTEST} > > +post-extract: > > Any reason why option helper target (post-extract-TEST-on) was not > used here? Simply unaware it existed, so this would change to: post-extract-TEST-on: ${INSTALL_DATA} ${FILESDIR}/Makefile.in ${WRKSRC}/Makefile ${INSTALL_DATA} ${FILESDIR}/test-minimal.cpp ... correct? -m > > ./danfe -- Michael Gmelin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170328165708.3feecd6a>