From owner-freebsd-multimedia Thu Apr 8 11:39:38 1999 Delivered-To: freebsd-multimedia@freebsd.org Received: from ns.mt.sri.com (sri-gw.MT.net [206.127.105.141]) by hub.freebsd.org (Postfix) with ESMTP id 05F9E14E2A; Thu, 8 Apr 1999 11:39:32 -0700 (PDT) (envelope-from nate@mt.sri.com) Received: from mt.sri.com (rocky.mt.sri.com [206.127.76.100]) by ns.mt.sri.com (8.8.8/8.8.8) with SMTP id MAA15180; Thu, 8 Apr 1999 12:37:25 -0600 (MDT) (envelope-from nate@rocky.mt.sri.com) Received: by mt.sri.com (SMI-8.6/SMI-SVR4) id MAA28461; Thu, 8 Apr 1999 12:37:24 -0600 Date: Thu, 8 Apr 1999 12:37:24 -0600 Message-Id: <199904081837.MAA28461@mt.sri.com> From: Nate Williams MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: Roger Hardiman Cc: Wes Peters , hackers@FreeBSD.ORG, multimedia@FreeBSD.ORG Subject: Re: Bt848 corruption since upgrading to 3.1. Has DMA code changed? In-Reply-To: <370CD277.E9A64E04@cs.strath.ac.uk> References: <370CB2DC.709E7CEA@cs.strath.ac.uk> <370CAA37.3645E2B9@softweyr.com> <370CD277.E9A64E04@cs.strath.ac.uk> X-Mailer: VM 6.34 under 19.16 "Lille" XEmacs Lucid Sender: owner-freebsd-multimedia@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org > > Does the driver explicitly turn on PCI bus mastering on the card? The > > PCI initialization code no longer does this. This change bit the fxp > > driver on some machines where the BIOS doesn't initialize bus mastering > > on the card. > > The driver has this code which enables the Bus Mastering. > It was added back in the days of 3.0-current (about 12 months ago) when > the driver > was common to 2.2.x and 3.x. That is why there is a #if around the code. > > #if __FreeBSD__ > 2 > fun = pci_conf_read(tag, PCI_COMMAND_STATUS_REG); > pci_conf_write(tag, PCI_COMMAND_STATUS_REG, fun | 4); > #endif Other than using a magic number of 4, that's almost the same as what's used in the fxp code. However, that also enables adds 0x2, which has another meaning. (It should be updated to not use the magic numbers, and instead use the constants supplied in , but that's a minor issue). Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-multimedia" in the body of the message