From owner-svn-src-all@FreeBSD.ORG  Sat Nov  7 19:00:24 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 136A8106568F;
	Sat,  7 Nov 2009 19:00:24 +0000 (UTC) (envelope-from sam@freebsd.org)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id DCEE08FC15;
	Sat,  7 Nov 2009 19:00:23 +0000 (UTC)
Received: from Macintosh-4.local ([10.0.0.198]) (authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id nA7J0NPg087853
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sat, 7 Nov 2009 11:00:23 -0800 (PST) (envelope-from sam@freebsd.org)
Message-ID: <4AF5C3C7.1020806@freebsd.org>
Date: Sat, 07 Nov 2009 11:00:23 -0800
From: Sam Leffler <sam@freebsd.org>
Organization: FreeBSD Project
User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
MIME-Version: 1.0
To: Doug Barton <dougb@freebsd.org>
References: <200911071842.nA7IgsNn060380@svn.freebsd.org>
In-Reply-To: <200911071842.nA7IgsNn060380@svn.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-DCC-x.dcc-servers-Metrics: ebb.errno.com; whitelist
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r199018 - head/sys/dev/wpi
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Nov 2009 19:00:24 -0000

Doug Barton wrote:
> Author: dougb
> Date: Sat Nov  7 18:42:53 2009
> New Revision: 199018
> URL: http://svn.freebsd.org/changeset/base/199018
> 
> Log:
>   Turn off WPI_DEBUG by default as the driver seems sufficiently stable
>   at this point.
>   
>   Reviewed by:	benjsc, thompsa
> 
> Modified:
>   head/sys/dev/wpi/if_wpi.c
> 
> Modified: head/sys/dev/wpi/if_wpi.c
> ==============================================================================
> --- head/sys/dev/wpi/if_wpi.c	Sat Nov  7 17:29:03 2009	(r199017)
> +++ head/sys/dev/wpi/if_wpi.c	Sat Nov  7 18:42:53 2009	(r199018)
> @@ -103,8 +103,6 @@ __FBSDID("$FreeBSD$");
>  #include <dev/wpi/if_wpireg.h>
>  #include <dev/wpi/if_wpivar.h>
>  
> -#define WPI_DEBUG
> -
>  #ifdef WPI_DEBUG
>  #define DPRINTF(x)	do { if (wpi_debug != 0) printf x; } while (0)
>  #define DPRINTFN(n, x)	do { if (wpi_debug & n) printf x; } while (0)
> 
> 

The right thing to do is to set wpi_debug to 0 and leave the messages
compiled in.

	Sam