From owner-svn-src-head@freebsd.org Sat Apr 1 07:44:30 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 13570D273BE; Sat, 1 Apr 2017 07:44:30 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mail-ua0-x22a.google.com (mail-ua0-x22a.google.com [IPv6:2607:f8b0:400c:c08::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C00BFBFC; Sat, 1 Apr 2017 07:44:29 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mail-ua0-x22a.google.com with SMTP id 17so6218542uah.0; Sat, 01 Apr 2017 00:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=68yTWtElqybhMi6KzviM5+md+n0wzv3hn27A5uznvVs=; b=Uk4gMCfgZk2vd+lH04Z6cZk/ZN4AIf0wK+lF94KdRO/L3eVaD8CeNJna5Kfer+cKSU /oUnvyHkDU3JRg9EbwzWxRbdBLGHdVZBlCB+HTMRwu9pUPIh/kKP8b7JcYgejeJ1AnWi t50h0AeGrPDq9V5LUjYQIxulWl5PupEnqWlWnblnBJLySrUsZ+9KUjTHy/at1+GGQ4B+ V6NKz1gJwXs9XEO/+6OciUkO7EwdUe1N/QvHOJ01SgwkQsrya9b/ma00jsHlE5UEOW8M 1oUsf1oL9ZSo8nJHqvOAUEm4Crzi68bwq2U/FGfmivoToiqON+0gJV6NHhh1WwjeQrTd 9JaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=68yTWtElqybhMi6KzviM5+md+n0wzv3hn27A5uznvVs=; b=ka4mOIdsEeAixf60n05Uz4cWs8RFSlaHt4Pnj5iK08nl1siZ5domjfyLm/c5m7URZz qQANnshonlbD5piKju278whLAhq0B30jekNqPiLKUjYv7e/DTT4c4LAtjWP3PP6m9rAk x0tkWjKlGTtwHFognwuNCwxgl9LU1orbn6045vDGz55ZMlt7vkfjKjF1yoIOeENmJZ+L CUkSRCjpUiDn94uviWw0K105O65rkOB5op/75nv7gpVQ7b68ya3z2zkrqxYLMAOC0em2 +m/XDRFK31uVf0NzhomnACZREImdN3gIMy8VGG9gWIWLZ+GzGVyYfT3x5h/8+8Kf8xxQ dRyQ== X-Gm-Message-State: AFeK/H1x+WbUSfKfnU3rqAbYdAix5XXCeyt0oBL+SIiKWHC4AtF7Xw4fsfJlKNZLYrG8cZjlvG11Hs2a/sFnhw== X-Received: by 10.176.6.129 with SMTP id g1mr3678777uag.68.1491032668754; Sat, 01 Apr 2017 00:44:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.76.72 with HTTP; Sat, 1 Apr 2017 00:44:28 -0700 (PDT) In-Reply-To: References: <201703302243.v2UMhX2s011405@repo.freebsd.org> <20170330230227.GH1016@strugglingcoder.info> <20170330231158.GI1016@strugglingcoder.info> From: Sepherosa Ziehau Date: Sat, 1 Apr 2017 15:44:28 +0800 Message-ID: Subject: Re: svn commit: r316309 - head/sys/dev/qlxgbe To: "Somayajulu, David" Cc: hiren panchasara , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , David C Somayajulu Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Apr 2017 07:44:30 -0000 Maybe it's time to add an IFCAP for HWLRO. On Fri, Mar 31, 2017 at 7:39 AM, Somayajulu, David wrote: >>> > I know this is not a new topic but a little more descriptive commit-log would have been nicer. Also, you should update the manpage reflecting this change. i.e. now it also supports software LRO when h/w LRO is disabled. >>> Will do. Sorry about that. > Minor correction. Please note that the driver provides the ability to choose between SoftwareLRO and HW LRO, when LRO is enabled - it is HW LRO by default. If LRO is turned off via ifconfig, neither Software nor HW LRO is enabled. > > Cheers > David S. > > -----Original Message----- > From: hiren panchasara [mailto:hiren@strugglingcoder.info] > Sent: Thursday, March 30, 2017 4:12 PM > To: Somayajulu, David > Cc: David C Somayajulu ; src-committers@freebsd.org; svn-src-all@freebsd.org; svn-src-head@freebsd.org > Subject: Re: svn commit: r316309 - head/sys/dev/qlxgbe > > On 03/30/17 at 11:07P, Somayajulu, David wrote: >> Hi Hiren, >> > I know this is not a new topic but a little more descriptive commit-log would have been nicer. Also, you should update the manpage reflecting this change. i.e. now it also supports software LRO when h/w LRO is disabled. >> Will do. Sorry about that. > > Thanks! >> >> > Do you know of a case where one would want to disable h/w lro and enable s/w lro? I guess where you want to free up nic and make cpu do more work? >> I was under the impression as well, that s/w lro is moot, if h/w lro was available, till one costumer asked for it. Not sure what the use case is. > > I thought this idea (like gro in linux) was popular when lro in h/w was considered buggy and couldn't correctly do batching (i.e. hide useful flags). Not sure if that's still the case. > > cheers, > Hiren > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" -- Tomorrow Will Never Die