From owner-cvs-all Thu Dec 16 14: 2:13 1999 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 8DFBB156CD; Thu, 16 Dec 1999 14:02:11 -0800 (PST) (envelope-from mckusick@FreeBSD.org) Received: (from mckusick@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id OAA39541; Thu, 16 Dec 1999 14:02:11 -0800 (PST) (envelope-from mckusick@FreeBSD.org) Message-Id: <199912162202.OAA39541@freefall.freebsd.org> From: Kirk McKusick Date: Thu, 16 Dec 1999 14:02:11 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/contrib/softupdates ffs_softdep.c Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk mckusick 1999/12/16 14:02:10 PST Modified files: sys/contrib/softupdates ffs_softdep.c Log: The function request_cleanup() had a tsleep() with PCATCH. It is quite dangerous, since the process may hold locks at the point, and if it is stopped in that tsleep the machine may hang. Because the sleep is so short, the PCATCH is not required here, so it has been removed. For the future, the FreeBSD team needs to decide whether it is still reasonable to stop a process in tsleep, as that may affect any other code that uses PCATCH while holding kernel locks. Submitted by: Dmitrij Tejblum Reviewed by: Kirk McKusick Revision Changes Path 1.40 +2 -2 src/sys/contrib/softupdates/ffs_softdep.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message