From owner-cvs-all Sat Mar 30 0:19:56 2002 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 313EE37B404; Sat, 30 Mar 2002 00:19:47 -0800 (PST) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.2/8.12.2) with ESMTP id g2U8JiYm068104; Sat, 30 Mar 2002 00:19:44 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.2/8.12.2/Submit) id g2U8ITLu068097; Sat, 30 Mar 2002 00:18:29 -0800 (PST) Date: Sat, 30 Mar 2002 00:18:29 -0800 From: "David O'Brien" To: Mark Murray Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/chpass Makefile chpass.c chpass.h edit.c field.c pw_copy.c pw_yp.c table.c util.c Message-ID: <20020330001829.B67334@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <200203241021.g2OALMU84291@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200203241021.g2OALMU84291@freefall.freebsd.org>; from markm@FreeBSD.org on Sun, Mar 24, 2002 at 02:21:22AM -0800 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Mar 24, 2002 at 02:21:22AM -0800, Mark Murray wrote: > markm 2002/03/24 02:21:22 PST > > Modified files: > usr.bin/chpass Makefile chpass.c chpass.h edit.c field.c > pw_copy.c pw_yp.c table.c util.c > Log: > Fix warns, ANSIfy, use __FBSDID(), sort headers. > > Revision Changes Path > 1.25 +1 -2 src/usr.bin/chpass/Makefile > http://cvsweb.freebsd.org/src/usr.bin/chpass/Makefile.diff?r1=1.24&r2=1.25 > 1.21 +9 -8 src/usr.bin/chpass/chpass.c > http://cvsweb.freebsd.org/src/usr.bin/chpass/chpass.c.diff?r1=1.20&r2=1.21 This is most likely a bad fix: +char localhost[] = "localhost"; did you try to make `yp_server' a "const char *" and then fix the yp functions so they take a const parameters for those arguments they do not modify. I fixed this type of change you made last time, if you want to see ways of doing it. The change you made just covers over the issue and allows you to do incomplete [lint] fixes. If you are going to lint the entire code base, I'd prefer the fixes were high quality, even when involved; vs. just covering over things lint complains about. -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message