From owner-svn-ports-all@FreeBSD.ORG Tue Mar 24 18:29:09 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7464CADF; Tue, 24 Mar 2015 18:29:09 +0000 (UTC) Received: from mailrelay111.isp.belgacom.be (mailrelay111.isp.belgacom.be [195.238.20.138]) by mx1.freebsd.org (Postfix) with ESMTP id 526CD1A0; Tue, 24 Mar 2015 18:29:07 +0000 (UTC) X-Belgacom-Dynamic: yes X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=o+amxqHLy7+dd/uQ+LUqZyoNQm/aGJUjZTPtnbq5Ku0= c=1 sm=2 a=IkcTkHD0fZMA:10 a=6I5d2MoRAAAA:8 a=1kfBrAnzEB6k8VmoRTkA:9 a=QEXdDO2ut3YA:10 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2BoBgBcqxFV/y+M8VFcgwZSTgyDEsM4hXUCgTxNAQEBAQEBfYQVAQUjMyMQCxgCAgUhAgIPKh4GE4gzAQivBJoTAQEBAQEBAQMBAQEBAQEBFwSBIYoAhEMzB4JogUUFlD+Ff5QtIoNvPTEBgkIBAQE Received: from 47.140-241-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.241.140.47]) by relay.skynet.be with ESMTP; 24 Mar 2015 19:27:59 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.9/8.14.9) with ESMTP id t2OIRuuM095966; Tue, 24 Mar 2015 19:27:57 +0100 (CET) (envelope-from tijl@FreeBSD.org) Date: Tue, 24 Mar 2015 19:27:56 +0100 From: Tijl Coosemans To: Thierry Thomas Subject: Re: svn commit: r381955 - head/graphics/gdal Message-ID: <20150324192756.06aea6da@kalimero.tijl.coosemans.org> In-Reply-To: <20150323210505.GN7893@graf.pompo.net> References: <201503222011.t2MKBHq7091087@svn.freebsd.org> <20150323015759.GA34402@FreeBSD.org> <550F8505.8010600@FreeBSD.org> <20150323135711.GB27378@ivaldir.etoilebsd.net> <5510220D.3030505@FreeBSD.org> <20150323143311.GC27378@ivaldir.etoilebsd.net> <20150323182248.GG7893@graf.pompo.net> <55105B9C.6030404@marino.st> <20150323210505.GN7893@graf.pompo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-ports-head@freebsd.org, Baptiste Daroussin , marino@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2015 18:29:09 -0000 On Mon, 23 Mar 2015 22:05:05 +0100 Thierry Thomas wro= te: > Le lun 23 mar 15 =C3=A0 19:29:48 +0100, John Marino > =C3=A9crivait=C2=A0: >>> Something like: >>> LDFLAGS+=3D ${PTHREAD_LIBS} >>>=20 >>> In these cases, it seems better to keep PTHREAD_LIBS than to hardcode >>> some variant of -lpthread. >>>=20 >>> Regards, >>>=20 >>=20 >> see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D198794 >>=20 >> 1) it's set to -pthread right now >> 2) PTHREAD_LIBS is supposed to disappear from ports. >=20 > I know, but I'm just suggesting to keep it for these cases. It used to be the case on FreeBSD that when you linked an executable to a library that used threading API you also had to link the executable with a threading library. So LDFLAGS+=3D${PTHREAD_LIBS} had to be added to ports sometimes if one of their dependencies used threading. It should be safe to remove these uses of ${PTHREAD_LIBS} now and then there won't be that many left. I think it's ok to replace them with -lpthread. There are other libraries missing sometimes and they don't have a special variable either.