From owner-svn-src-all@freebsd.org Thu Jun 25 15:07:13 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7503B98DFAC; Thu, 25 Jun 2015 15:07:13 +0000 (UTC) (envelope-from ermal.luci@gmail.com) Received: from mail-yh0-x233.google.com (mail-yh0-x233.google.com [IPv6:2607:f8b0:4002:c01::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3032E194E; Thu, 25 Jun 2015 15:07:13 +0000 (UTC) (envelope-from ermal.luci@gmail.com) Received: by yhfk64 with SMTP id k64so13651560yhf.2; Thu, 25 Jun 2015 08:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=LexhXaI3V7d+9cn0tTKrFh14HE+1Df0CD85s3RCSVdg=; b=vquUu+JL8s184Fvgj8w2UGqSPkFDEE3pGbtz9eq85JCYI1n6iRLqwsya5gT+N6Mq7j m4nPZu+jVBgzSa8dhgp9vIn1QlFA63pwBwKdOfxWuqRRjQNXuM0mvw9YW54s3EYAFboL KjTRlfJLNo7A4Lmk0WraGxnWNqrjQg7EmUtiMIiDlHdO/Sb5IL15hUUoHvhJsrDtErrF EcyimU198ZLMkXHKs9wLvFWmMveMW5Hc+pE6o60XmIJX2RM2HQDvMqG2EtT+zdnYQ5c5 LDOVuSnM033tGhpbZt0UjyHlUj+rgDd5Bj0YUHSaweLgFeq/In2YvFEtCxu3phKo8RFT urNg== MIME-Version: 1.0 X-Received: by 10.170.114.199 with SMTP id g190mr349178ykb.128.1435244832205; Thu, 25 Jun 2015 08:07:12 -0700 (PDT) Sender: ermal.luci@gmail.com Received: by 10.129.83.139 with HTTP; Thu, 25 Jun 2015 08:07:12 -0700 (PDT) In-Reply-To: References: <201506241916.t5OJGfEm025914@svn.freebsd.org> <76B695F2-AEDE-4BF3-8BE3-97CA8A98780D@FreeBSD.org> Date: Thu, 25 Jun 2015 17:07:12 +0200 X-Google-Sender-Auth: Cw_i3KgcgbbO-g-I8sJr-wZ9zjY Message-ID: Subject: Re: svn commit: r284777 - in head: sbin/pfctl share/man/man4 sys/conf sys/net/altq sys/netpfil/pf From: =?UTF-8?Q?Ermal_Lu=C3=A7i?= To: "Bjoern A. Zeeb" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2015 15:07:13 -0000 Fixed. On Thu, Jun 25, 2015 at 11:00 AM, Ermal Lu=C3=A7i wrote: > > On Thu, Jun 25, 2015 at 10:42 AM, Bjoern A. Zeeb wrote: > >> >> > On 24 Jun 2015, at 19:16 , Ermal Lu=C3=A7i wrote: >> > >> > Author: eri >> > Date: Wed Jun 24 19:16:41 2015 >> > New Revision: 284777 >> > URL: https://svnweb.freebsd.org/changeset/base/284777 >> > >> > Log: >> > ALTQ FAIRQ discipline import from DragonFLY >> > >> > Differential Revision: https://reviews.freebsd.org/D2847 >> > Reviewed by: glebius, wblock(manpage) >> > Approved by: gnn(mentor) >> > Obtained from: pfSense >> > Sponsored by: Netgate >> >> I see a lot of kernel configurations failing to build dring a universe; >> here=E2=80=99s some errors: >> >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: expected >> declaration specifiers or '...' before 'pf_keyhash' >> cc1: warnings being treated as errors >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1461: error: expected >> declaration specifiers or '...' before 'pf_idhash' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1461: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1464: error: expected >> declaration specifiers or '...' before 'pf_srchash' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1464: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1469: error: expected >> declaration specifiers or '...' before 'pf_swi_cookie' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1469: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1472: error: expected >> declaration specifiers or '...' before 'pf_stateid' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1472: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1476: error: expected >> declaration specifiers or '...' before 'pf_altqs' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1476: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1478: error: expected >> declaration specifiers or '...' before 'pf_pabuf' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1478: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1481: error: expected >> declaration specifiers or '...' before 'ticket_altqs_active' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1481: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1483: error: expected >> declaration specifiers or '...' before 'ticket_altqs_inactive' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1483: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1485: error: expected >> declaration specifiers or '...' before 'altqs_inactive_open' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1485: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1487: error: expected >> declaration specifiers or '...' before 'ticket_pabuf' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1487: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1489: error: expected >> declaration specifiers or '...' before 'pf_altqs_active' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1489: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1491: error: expected >> declaration specifiers or '...' before 'pf_altqs_inactive' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1491: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1494: error: expected >> declaration specifiers or '...' before 'pf_unlinked_rules' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1494: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1508: error: expected >> declaration specifiers or '...' before 'pf_state_z' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1508: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1510: error: expected >> declaration specifiers or '...' before 'pf_state_key_z' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1510: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1512: error: expected >> declaration specifiers or '...' before 'pf_state_scrub_z' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1512: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1558: error: expected >> declaration specifiers or '...' before 'sync_ifp' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1558: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1560: error: expected >> declaration specifiers or '...' before 'pf_default_rule' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1560: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1648: error: expected >> declaration specifiers or '...' before 'pfi_all' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1648: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1675: error: expected >> declaration specifiers or '...' before 'pf_status' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1675: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1682: error: expected >> declaration specifiers or '...' before 'pf_limits' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1682: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1688: error: expected >> declaration specifiers or '...' before 'pf_anchors' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1688: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1690: error: expected >> declaration specifiers or '...' before 'pf_main_anchor' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1690: error: conflicting types >> for 'VNET_DECLARE' >> /scratch/tmp/bz/head.svn/sys/net/pfvar.h:1460: error: previous >> declaration of 'VNET_DECLARE' was here >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c: In function >> 'fairq_pfattach': >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c:141: error: >> dereferencing pointer to incomplete type >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c: In function >> 'fairq_add_altq': >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c:155: error: >> dereferencing pointer to incomplete type >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c:163: error: >> dereferencing pointer to incomplete type >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c: In function >> 'fairq_request': >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c:275: error: >> dereferencing pointer to incomplete type >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c:280: error: >> 'ALTRQ_PURGE' undeclared (first use in this function) >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c:280: error: (Each >> undeclared identifier is reported only once >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c:280: error: for each >> function it appears in.) >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c: In function >> 'fairq_purge': >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c:299: error: >> dereferencing pointer to incomplete type >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c: In function >> 'fairq_class_create': >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c:387: error: >> dereferencing pointer to incomplete type >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c: In function >> 'fairq_enqueue': >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c:478: error: >> dereferencing pointer to incomplete type >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c:490: error: >> dereferencing pointer to incomplete type >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c: In function >> 'fairq_dequeue': >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c:531: error: >> dereferencing pointer to incomplete type >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c:546: error: >> 'ALTDQ_REMOVE' undeclared (first use in this function) >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c:587: error: >> 'ALTDQ_POLL' undeclared (first use in this function) >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c: In function >> 'fairq_addq': >> /scratch/tmp/bz/head.svn/sys/net/altq/altq_fairq.c: In function >> 'fairq_pollq': >> --- altq_fairq.o --- >> >> > Let me check this and fix quickly though i could not run 'make universe' = i > have not seen such issues before since this a patch being used for more > than 3 years in production. > >> >> =E2=80=94 >> Bjoern A. Zeeb Charles Haddon Spurgeon: >> "Friendship is one of the sweetest joys of life. Many might have failed >> beneath the bitterness of their trial had they not found a friend." >> >> > > > -- > Ermal > --=20 Ermal