From nobody Tue Jul 14 14:56:19 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h02SN2NsMz6kqhl for ; Tue, 14 Jul 2026 14:56:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h02SM657cz3Lpm for ; Tue, 14 Jul 2026 14:56:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784040979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GKlaiCXHlBQjwHRog1ySkw0uA+4QfwM8lny4OlO6wdQ=; b=vHgNSa+3xr5nVfjW2u3udCsmn3vbE5Imabj/ex080lCzOBUxihA/A0BaSEUDjCs78sw+R0 SESsOvzlA0YYuGjRRzMii+hBTfiwFiWcJbMLxmndDKbOfCFCjyBTIwM5ZiNiMYxwMAiMWm QfxHIFyoKj6fflHzrAmJeEKNJYAfOxa35GBdsb1jzu2Ft+irYRD0oOG4c0PrcsrLhlXKX1 DZK/wsOGkmdxPiMWfvZ7qB7GnrLcShwSGyJ4GSvJ53JsJhYaVt4wFcozq4BeifzKUYRUut gAG33tMAGnotBzjCTTywY3+lCUWW7uYK1zbdDDuYNcrNZxVOpcOq1JnI4JpElg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1784040979; a=rsa-sha256; cv=none; b=GSsdpQClt+aj87L2FuqeHe6Qrjg4irlMY6b0z7pmKOEmqIE5KSVNFwMxCpE932CER3IxNg K09Qomxe4HOqkzd4SDBZ27rHvFMEwEKaU/47mxuibLkuMX/H83rFLZLJLkRwIq6z0j5bf7 IAxDrhCqQnm5M5CnCxQk4sa8Mut1mjktTiGeJeT6pkUdqLGe/ffHG8HAbEvYR2/7ljMjEn vNBg5uPoFybiVLaWzcmpdPd+RPrTUjrNsAJdPEyMsmcbqMW5Zn/MocNuXPNEBAO+EB0vAQ kdkNSxO+YsxfwUE6r3htRXeeWh0T6D5mWXj68mNzfonNE/u4sZnaUO6rTneuPg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784040979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GKlaiCXHlBQjwHRog1ySkw0uA+4QfwM8lny4OlO6wdQ=; b=oA/h+mBfUp+tB9PJtsIx6FTrOPdqFF9vewgGpaCgHhHTdeWb1/G/xLjwrS6dGdn7wSv5kH Q9qKCgEs2LvohJcJck2k7lIoMLe6t2+N1o4ppJGxksQDiJqfHkWtFQU5gXAs2yH7yPAqje u9R2smxwKqq4raIcdta8Arsf6Frk/kEUTq8mJl7p47YiVtUtCmLNMs1JmgzbFyXyXKCPOu II35z/y/YEqQgazBNv3iEYZdn8D//4H17YdtoQZMyFquhGpcaxB73geoUiogiwr3jSMbK6 yeRPfzskw4hFdrn41noul9Yp657lQFIaief8ns8F5/q0zGD1zWbO5KTu2hwECQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h02SM4wr2zq1t for ; Tue, 14 Jul 2026 14:56:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3dc22 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 14 Jul 2026 14:56:19 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Jane Smith From: Mark Johnston Subject: git: eba4bf368329 - stable/14 - librpcsec_gss: Fix an off-by-one in rpc_gss_get_principal_name() List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: eba4bf368329eab4609b5b05589ba4f344c4f2a9 Auto-Submitted: auto-generated Date: Tue, 14 Jul 2026 14:56:19 +0000 Message-Id: <6a564e13.3dc22.5654db69@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=eba4bf368329eab4609b5b05589ba4f344c4f2a9 commit eba4bf368329eab4609b5b05589ba4f344c4f2a9 Author: Jane Smith AuthorDate: 2026-06-22 21:40:53 +0000 Commit: Mark Johnston CommitDate: 2026-07-14 14:08:40 +0000 librpcsec_gss: Fix an off-by-one in rpc_gss_get_principal_name() Include an extra byte for the nul-terminator, otherwise we may end up with an out-of-bounds write. The corresponding bug in the kernel implementation was fixed by commit e3081f7e3e2d ("kgssapi(4): Fix string overrun in Kerberos principal construction"). Reviewed by: markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D57738 (cherry picked from commit 635ad6f2ec97e9c6b1f15620cd5ee84eb632082f) --- lib/librpcsec_gss/svc_rpcsec_gss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librpcsec_gss/svc_rpcsec_gss.c b/lib/librpcsec_gss/svc_rpcsec_gss.c index 73b92371e6d0..a15542330697 100644 --- a/lib/librpcsec_gss/svc_rpcsec_gss.c +++ b/lib/librpcsec_gss/svc_rpcsec_gss.c @@ -247,7 +247,7 @@ rpc_gss_get_principal_name(rpc_gss_principal_t *principal, * Construct a gss_buffer containing the full name formatted * as "name/node@domain" where node and domain are optional. */ - namelen = strlen(name); + namelen = strlen(name) + 1; if (node) { namelen += strlen(node) + 1; }