From owner-svn-src-all@freebsd.org Fri Nov 2 08:46:21 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 631E210EDC6B; Fri, 2 Nov 2018 08:46:21 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CF1317D44E; Fri, 2 Nov 2018 08:46:20 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wr1-x441.google.com with SMTP id y16so1140659wrw.3; Fri, 02 Nov 2018 01:46:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=zDPEB1Rdi3c52hUFDWSrrw5W3wE4bvh126HBwBZ/VWw=; b=EdwtNhf9WtWl3WGC8nqDj+OvbhoeQOIbm5ctH4XqvCzm5m21s+b3dd6YspJHe4UI8B F8r2wSwEFk6frmhOLE9cOd9iSDzIsf+qfOYXBOL5xTgAN2Xs2vI6GTxi87994PPGzcuj WW8uoZ0ejOq7bIHNx+CigS87+teYFR7tD1HtWB7qIYZmuUVgvaZYluLSTgVOpqcGlutd rtVT/Ig7q4sZVKDUk17jwK6KPtk+LzkNnwG6Unj4esWQLTG8dBx5V41Ys4n0WA3KTagc aXP1RJ70o4WjdnolLqvpKCJJxq8V//yZNJKaikfMpZWoI91OY8/ZC2Aq0TEEeda410ff 8lzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=zDPEB1Rdi3c52hUFDWSrrw5W3wE4bvh126HBwBZ/VWw=; b=E/56xsrSgQta2nzbse4hywjnFYrOUgh7PkS5LkkFOgJYS7ZupxOB4M44LV7WPTQRY2 Le/3uVtQiCaG911CY90+XhMxmrR56UpBAr1V5j9rq9w8WxmORedxV1GzUGEln9to/vqN MERZ/SY3JCWsHac1OF8OYpUwKE5BCKwm2uy9jfTW7NPCdk6gRKrLNOBd4bsztf3vJkew DD2FU3M4A3a83kOx3ovVCWLGlOlIOzmA+NGQf46d5bzTFXlaZtlxZMOVJkYkP1bUufcp t01obqpk7c0wREo6RcCk/qRMWtmefKQnt3UD+cS0aDTpqrhpUSBq9MAVgxrWrp+cnxJl y1IQ== X-Gm-Message-State: AGRZ1gKZy80Mhr1CDo18tzJkO5trM2apE8GcdW8ysy2xYb2oNjYYWDdM hc86N+7gdtF1zrqQidWjSUOxzvRd X-Google-Smtp-Source: AJdET5dMu/ypPUNKXVXNhFTBAMWcENHiau5qWw1mZ87VhhNx9dwPAdFFNxK57CcVY/Rzxd92/nCTiQ== X-Received: by 2002:adf:ead0:: with SMTP id o16-v6mr9912197wrn.287.1541148379420; Fri, 02 Nov 2018 01:46:19 -0700 (PDT) Received: from ernst.home (p5B02380D.dip0.t-ipconnect.de. [91.2.56.13]) by smtp.gmail.com with ESMTPSA id e8-v6sm6823877wrw.75.2018.11.02.01.46.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 02 Nov 2018 01:46:18 -0700 (PDT) Date: Fri, 2 Nov 2018 09:46:17 +0100 From: Gary Jennejohn To: Conrad Meyer Cc: Konstantin Belousov , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Subject: Re: svn commit: r340038 - in head: lib/libc/sys sys/kern Message-ID: <20181102094617.7340e6f2@ernst.home> In-Reply-To: References: <201811012346.wA1NkNS5079845@repo.freebsd.org> <20181102004555.GJ5335@kib.kiev.ua> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; amd64-portbld-freebsd12.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 08:46:21 -0000 On Thu, 1 Nov 2018 20:29:27 -0700 Conrad Meyer wrote: > On Thu, Nov 1, 2018 at 5:46 PM Konstantin Belousov wrote: > > > > On Thu, Nov 01, 2018 at 11:46:23PM +0000, Conrad Meyer wrote: > > > ... > > > @@ -232,7 +232,15 @@ points outside the process's allocated address space. > > > A signal was delivered before the time limit expired and > > > before any of the selected events occurred. > > > .It Bq Er EINVAL > > > -The specified time limit is invalid. One of its components is negative or too large. > > > +The specified time limit is invalid. > > > +One of its components is negative or too large. > > > +.It Bq Er EINVAL > > > +The number of pollfd structures specified by > > > +.Fa nfds > > > +exceeds the system tunable > > > +.Va kern.maxfilesperproc > > > +and > > > +.Dv FD_SETSIZE . > > > > This is somewhat confusing. Looking only at the man page text, most > > straight reading of it is that nfds cannot exceed min(maxfilesperproc, > > FD_SETSIZE). But in fact nfds cannot exceed max of it, which is > > significantly different, i.e. poll(2) does not suffer from the (userspace) > > FD_SETSIZE limitation of select(2). > > min(maxfilesperproc, FD_SETSIZE) would be written as "nfds exceeds ... > maxfilesperproc OR FD_SETSIZE," rather than "and." I think the > sentence is unambiguous. > Based on Konstantin's comment I'd have to say that it is not unambiguous. As a native English speaker I had to read it several times to understand it. I think something like "exceeds both" might be clearer. -- Gary Jennejohn