From owner-cvs-src@FreeBSD.ORG Mon Jun 12 17:20:47 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C1FD016A41A; Mon, 12 Jun 2006 17:20:47 +0000 (UTC) (envelope-from nate@root.org) Received: from ylpvm12.prodigy.net (ylpvm12-ext.prodigy.net [207.115.57.43]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4022A43D49; Mon, 12 Jun 2006 17:20:45 +0000 (GMT) (envelope-from nate@root.org) Received: from pimout7-ext.prodigy.net (pimout7-int.prodigy.net [207.115.4.147]) by ylpvm12.prodigy.net (8.12.10 outbound/8.12.10) with ESMTP id k5CHKUuo030036; Mon, 12 Jun 2006 13:20:31 -0400 X-ORBL: [71.139.104.128] Received: from [10.0.5.50] (ppp-71-139-104-128.dsl.snfc21.pacbell.net [71.139.104.128]) by pimout7-ext.prodigy.net (8.13.6 out.dk/8.13.6) with ESMTP id k5CHKfBR135214; Mon, 12 Jun 2006 13:20:42 -0400 Message-ID: <448DA202.5020009@root.org> Date: Mon, 12 Jun 2006 10:18:58 -0700 From: Nate Lawson User-Agent: Thunderbird 1.5.0.2 (X11/20060501) MIME-Version: 1.0 To: =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= References: <200606112031.k5BKVf8u056762@repoman.freebsd.org> <867j3m2ujs.fsf@xps.des.no> In-Reply-To: <867j3m2ujs.fsf@xps.des.no> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jun 2006 17:20:47 -0000 Dag-Erling Smørgrav wrote: > Nate Lawson writes: >> Log: >> By default, don't disable ACPI during reboot. This appears to hang some >> systems. Introduce a new sysctl "hw.acpi.disable_on_reboot" that allows >> users to re-enable the old behavior in case it's needed for some systems. >> We never disable in the power-off path. > > Seems like you forgot something: > > cc -O2 -pipe -march=pentium4 -DACPI_USE_LOCAL_CACHE -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I- -I/usr/src/sys/modules/acpi/acpi/../../../contrib/dev/acpica -DHAVE_KERNEL_OPTION_HEADERS -include /usr/obj/usr/src/sys/xps/opt_global.h -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common -g -I/usr/obj/usr/src/sys/xps -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -fformat-extensions -std=c99 -c /usr/src/sys/modules/acpi/acpi/../../../dev/acpica/acpi.c > /usr/src/sys/modules/acpi/acpi/../../../dev/acpica/acpi.c: In function `acpi_attach': > /usr/src/sys/modules/acpi/acpi/../../../dev/acpica/acpi.c:525: error: structure has no member named `acpi_do_disable' > /usr/src/sys/modules/acpi/acpi/../../../dev/acpica/acpi.c: In function `acpi_shutdown_final': > /usr/src/sys/modules/acpi/acpi/../../../dev/acpica/acpi.c:1672: error: structure has no member named `acpi_do_disable' > *** Error code 1 > > DES Thanks, wasn't in the original commit but was in the MFC. pointy hat for today -- Nate