From owner-freebsd-net@FreeBSD.ORG Tue Mar 6 15:46:50 2007 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0C40516A408; Tue, 6 Mar 2007 15:46:50 +0000 (UTC) (envelope-from bms@incunabulum.net) Received: from out5.smtp.messagingengine.com (out5.smtp.messagingengine.com [66.111.4.29]) by mx1.freebsd.org (Postfix) with ESMTP id D4AE813C481; Tue, 6 Mar 2007 15:46:49 +0000 (UTC) (envelope-from bms@incunabulum.net) Received: from out1.internal (unknown [10.202.2.149]) by out1.messagingengine.com (Postfix) with ESMTP id 42E651F50E6; Tue, 6 Mar 2007 10:46:49 -0500 (EST) Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by out1.internal (MEProxy); Tue, 06 Mar 2007 10:46:49 -0500 X-Sasl-enc: s9FqcU+WZeIQ2Lm35vXbKDCcAh9Inppn7BKCozRSQ4EI 1173196009 Received: from [192.168.123.18] (82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254]) by mail.messagingengine.com (Postfix) with ESMTP id 92EFF33FB1; Tue, 6 Mar 2007 10:46:48 -0500 (EST) Message-ID: <45ED8CE6.5030908@incunabulum.net> Date: Tue, 06 Mar 2007 15:46:46 +0000 From: Bruce M Simpson User-Agent: Thunderbird 1.5.0.9 (X11/20070125) MIME-Version: 1.0 To: Yar Tikhiy References: <45E8B964.2090200@incunabulum.net> <20070303215359.GB40430@comp.chem.msu.su> <45EA0756.2000107@incunabulum.net> <20070304070458.GG40430@comp.chem.msu.su> <45EB750A.90105@incunabulum.net> <20070305142411.GC57253@comp.chem.msu.su> <45EC2C37.7020604@incunabulum.net> <20070305154824.GE57253@comp.chem.msu.su> In-Reply-To: <20070305154824.GE57253@comp.chem.msu.su> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-net@freebsd.org, Kip Macy Subject: Re: [PATCH] Ethernet cleanup; 802.1p input and M_PROMISC X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2007 15:46:50 -0000 Yar Tikhiy wrote: > My proposed check for IFF_DRV_RUNNING is by no means a priority > task. I can add it by myself after you finish your great current > project regarding ether_input() and friends. > Just committed in p4: ==== //depot/user/bms/netdev/sys/net/if_ethersubr.c#6 - /home/bms/p4/netdev/sys/net/if_ethersubr.c ==== --- /tmp/tmp.11470.0 Tue Mar 6 15:45:08 2007 +++ /home/bms/p4/netdev/sys/net/if_ethersubr.c Tue Mar 6 15:45:01 2007 @@ -511,6 +511,13 @@ m_freem(m); return; } +#ifdef DIAGNOSTIC + if ((ifp->if_flags & IFF_DRV_RUNNING) == 0) { + if_printf(ifp, "discard frame at !IFF_DRV_RUNNING\n"); + m_freem(m); + return; + } +#endif Thanks! BMS