From nobody Sun Sep 14 08:14:22 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cPgtQ1wZyz67Z45; Sun, 14 Sep 2025 08:14:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cPgtQ11HWz3nDK; Sun, 14 Sep 2025 08:14:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757837662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GgVCMRk2loYAKPbG3qH3mxTaTXcT59NZ5dZKLWJ6O6A=; b=lL2IamldZa0yRG4d+Hlle5OgORVzGddyOl44Ha9Bene0D6MufJqJugW2gOXst4MxGpwfL2 C+MaihTGWDJ5oh7a0XdZfofh+jeq+Ly6L+7T3cvZeK0rFzyHfoSzXWmYLr4K+d9wn7Pj5t 7cHJhizjSGFfE9SKSothMRAv4bQiPFTxoXkdYYNp6r4BUHCJYNjA4YPG12lFUJYPlyZOAC lYwj3sGh5XaRlqjML7Wav7gnbUdN7mDGv+uSs/llc0oYOMFfoU+5fHHSQ5fe/42WxOpBpa fWwEP0uZfkrnbRGht5Sm+nTPXLBixDLF+ny4P4krA0r5loID9cw62RKc9qBSbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757837662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GgVCMRk2loYAKPbG3qH3mxTaTXcT59NZ5dZKLWJ6O6A=; b=YFKlW0ZSLcnjEwziMsYN/A/YCcSA0q8jSuLe1TjNkyHVNim/eWPgZwLi3QRXTIRwwcn1N5 nhqYNLj4GURl3HmBazH4cfJ4KfkZfN74z4j7l4u6JMvIGdPIAGiFh24TohmLkAU2fNwfNK rg3BWBnOpOdgT/KOhEtD3ZfUMXPPN7Xl483CXv49HiLCgi+nZ6fdZNGt4Q6lSWh/HSzdRQ Tea/5IZpbF7S1ziw0h03aFPMHSaKyoUTQzzpBfpUYuRaUPUf4I4T4DkVk0UCcDM1OX8jWu JGpYCdc3CU4iVEZphWMVprWa+2+PfmZyJHQySDBu/gtoMVjbEpNnF/alS3h+xQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1757837662; a=rsa-sha256; cv=none; b=P/1cxn+QG8+OM0I+XjhQqni938kL3D9JvHj15ibAS4q4I4BHW8daoal0C12MUJ+sRK5Gko 4xmrBr24BUFDp+UKpqLqm58RjUVae3r9y/nJxWXDJg8a2iL67FmpRF1cMbmkFltZmySTpo YKdoONSN2aW3gNR+iQ9/LD+VUqkAM7vNyWCTg2fwWt3QWgC4+kzypQXTMGsJ1rI/It5qOc gcy+SDegUN00o879XvClMVq49azoWsudcQfyezB8j7MMhcWtGRGcaTWpfCne9ibCAlNouH 4NwyTSZ95Ay615hP1MUKJrxfwfUMr5kYK7Xsa2SGHXXrF/e5q2rrdgkPEdlqhQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cPgtQ0YsTz1GH4; Sun, 14 Sep 2025 08:14:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58E8EM8n013267; Sun, 14 Sep 2025 08:14:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58E8EM8L013264; Sun, 14 Sep 2025 08:14:22 GMT (envelope-from git) Date: Sun, 14 Sep 2025 08:14:22 GMT Message-Id: <202509140814.58E8EM8L013264@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: a85525a5c8b2 - main - pdgetpid(2): switch back returning EBADF for non-procdesc fd List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a85525a5c8b28f1516d49e5d6ae5842873c24643 Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=a85525a5c8b28f1516d49e5d6ae5842873c24643 commit a85525a5c8b28f1516d49e5d6ae5842873c24643 Author: Konstantin Belousov AuthorDate: 2025-09-13 19:23:27 +0000 Commit: Konstantin Belousov CommitDate: 2025-09-14 08:11:03 +0000 pdgetpid(2): switch back returning EBADF for non-procdesc fd This partially reverts fd9e09cb2ab0, since apparently QT depends on this specific error code. It seems that it applies pdgetpid() to random fds and filters non-procdescs by checking errno for EBADF. Reported by: arrowd, Kenneth Raplee Sponsored by: The FreeBSD Foundation MFC after: 1 week --- sys/kern/sys_procdesc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/sys_procdesc.c b/sys/kern/sys_procdesc.c index 54b03fc82c90..acaf1241cb2e 100644 --- a/sys/kern/sys_procdesc.c +++ b/sys/kern/sys_procdesc.c @@ -175,7 +175,7 @@ kern_pdgetpid(struct thread *td, int fd, const cap_rights_t *rightsp, if (error) return (error); if (fp->f_type != DTYPE_PROCDESC) { - error = EINVAL; + error = EBADF; goto out; } *pidp = procdesc_pid(fp);