From owner-svn-src-all@FreeBSD.ORG Thu Jan 1 04:15:58 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 303D26D1; Thu, 1 Jan 2015 04:15:58 +0000 (UTC) Received: from mail-pd0-x22d.google.com (mail-pd0-x22d.google.com [IPv6:2607:f8b0:400e:c02::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E8B5166FB4; Thu, 1 Jan 2015 04:15:57 +0000 (UTC) Received: by mail-pd0-f173.google.com with SMTP id ft15so21820434pdb.32; Wed, 31 Dec 2014 20:15:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=Fs+iPn/X4mbrlNFL4toLBqj5o6Q8MPH0mVo9nw78ngE=; b=EjMsrhK+iHJRsR0ITcAHh3E5aqIGk7gv3hvJbRBFDSTZFdDiOEJ0vzD7bAyffI7Ug4 1kUVzStL8+jJSDRO8GjbMkKzI9VIXswVUh1gK4Jj37k1NePXlcEJW0Y/XYjDRmhAVikn fSLo59lc+MYoEswnJvcKjfxHKwrEzh7aU6EazBE23DHnEHh07Y0nIJCmbmHebC9AKNrR 41LeobWLDDkRGu5grLUAasFjc59WcHjvbmt/n8ZmeX2B++qD0wwxZTEHkYdddITuNgY6 k77J53i6Bdkf2mgEz9OwxoJKK1l6LzGwDeNL7k3bKn7lieHQFOIKKjsHczODaK1bI6O6 FDcw== X-Received: by 10.70.123.10 with SMTP id lw10mr100824619pdb.161.1420085757410; Wed, 31 Dec 2014 20:15:57 -0800 (PST) Received: from ?IPv6:2601:8:ab80:7d6:89e5:192b:a505:2a25? ([2601:8:ab80:7d6:89e5:192b:a505:2a25]) by mx.google.com with ESMTPSA id rh11sm42566630pdb.66.2014.12.31.20.15.56 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 31 Dec 2014 20:15:56 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_954921B5-610B-4E89-A6FF-453E862FCFC8"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r276488 - in head: share/mk sys/arm/broadcom/bcm2835 sys/conf From: Garrett Cooper In-Reply-To: <27B917EC-CB35-4BF6-AB8F-4CBF56EC3E41@bsdimp.com> Date: Wed, 31 Dec 2014 20:15:55 -0800 Message-Id: References: <201501010200.t01205Ge007058@svn.freebsd.org> <760D3407-921D-4249-9DC2-74610FA46920@FreeBSD.org> <27B917EC-CB35-4BF6-AB8F-4CBF56EC3E41@bsdimp.com> To: Warner Losh X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, Warner Losh , svn-src-all@freebsd.org, src-committers , Dimitry Andric X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jan 2015 04:15:58 -0000 --Apple-Mail=_954921B5-610B-4E89-A6FF-453E862FCFC8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Dec 31, 2014, at 20:12, Warner Losh wrote: >> On Dec 31, 2014, at 8:52 PM, Dimitry Andric wrote: >>=20 >> On 01 Jan 2015, at 03:00, Warner Losh wrote: >>>=20 >>> Author: imp >>> Date: Thu Jan 1 02:00:04 2015 >>> New Revision: 276488 >>> URL: https://svnweb.freebsd.org/changeset/base/276488 >>>=20 >>> Log: >>> Fix module builds on arm (and maybe others) by turning off a whole >>> raft of new warnings that appear to be on by default in clang 3.5.0. >>> Fix RPI-B build issues with new clang not liking the ability to pass >>> arbitrary flags to as, since some flags are more arbitrary (and thus >>> verboten) than others. >>>=20 >>> These warnings should be actually fixed in the code, but this is a >>> band-aide to get things (almost) building again. >>>=20 >>> Modified: >>> head/share/mk/bsd.kmod.mk >>> head/share/mk/bsd.sys.mk >>> head/sys/arm/broadcom/bcm2835/std.bcm2835 >>> head/sys/conf/kern.mk >>>=20 >>> Modified: head/share/mk/bsd.kmod.mk >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- head/share/mk/bsd.kmod.mk Thu Jan 1 01:43:00 2015 = (r276487) >>> +++ head/share/mk/bsd.kmod.mk Thu Jan 1 02:00:04 2015 = (r276488) >>> @@ -13,5 +13,3 @@ SYSDIR=3D ${_dir} >>> .endif >>>=20 >>> .include "${SYSDIR}/conf/kmod.mk" >>> - >>> -.include >>>=20 >>> Modified: head/share/mk/bsd.sys.mk >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- head/share/mk/bsd.sys.mk Thu Jan 1 01:43:00 2015 = (r276487) >>> +++ head/share/mk/bsd.sys.mk Thu Jan 1 02:00:04 2015 = (r276488) >>> @@ -110,11 +110,7 @@ CWARNFLAGS+=3D -Wno-format >>> CWARNFLAGS+=3D -Wno-unknown-pragmas >>> .endif # IGNORE_PRAGMA >>>=20 >>> -.if ${COMPILER_TYPE} =3D=3D "clang" >>> -# Would love to do this unconditionally, but can't due to its use = in >>> -# kernel build coupled with CFLAGS.${TARGET} feature >>> CLANG_NO_IAS=3D -no-integrated-as >>> -.endif >>> CLANG_OPT_SMALL=3D -mstack-alignment=3D8 -mllvm -inline-threshold=3D3\= >>> -mllvm -simplifycfg-dup-ret -mllvm -enable-gvn=3Dfalse >>> CFLAGS.clang+=3D -Qunused-arguments >>=20 >> This should not be removed from bsd.sys.mk, since other things depend = on >> it, are you sure that you want this? :) >=20 > I may be wrong here for boot stuff that uses it. >=20 >> As far as I know, there are still a few places in the tree that use = the >> CLANG_NO_IAS macro. It would be nice if those all went away, though=85= >=20 > Only for boot. Thanks, though I think they may be CFLAGS.clang +=3D = there. >=20 >> Modified: head/sys/arm/broadcom/bcm2835/std.bcm2835 >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- head/sys/arm/broadcom/bcm2835/std.bcm2835 Thu Jan 1 = 01:43:00 2015 (r276487) >>> +++ head/sys/arm/broadcom/bcm2835/std.bcm2835 Thu Jan 1 = 02:00:04 2015 (r276488) >>> @@ -2,7 +2,7 @@ >>>=20 >>> machine arm armv6 >>> cpu CPU_ARM1176 >>> -makeoptions CONF_CFLAGS=3D"-mcpu=3Darm1176jzf-s = -Wa,-mcpu=3Darm1176jzf-s" >>> +makeoptions CONF_CFLAGS=3D"-mcpu=3Darm1176jzf-s" >>>=20 >>> files "../broadcom/bcm2835/files.bcm2835" >>>=20 >>>=20 >>> Modified: head/sys/conf/kern.mk >>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- head/sys/conf/kern.mk Thu Jan 1 01:43:00 2015 = (r276487) >>> +++ head/sys/conf/kern.mk Thu Jan 1 02:00:04 2015 = (r276488) >>> @@ -164,4 +164,26 @@ CFLAGS+=3D -fstack-protector >>> CFLAGS+=3D -gdwarf-2 >>> .endif >>>=20 >>> +# A whole bunch of new default warnings in clang 3.5 subpress for = now until >>> +# this can be cleaned up. >>> +.if ${COMPILER_VERSION} >=3D 30500 >>> +CFLAGS.clang+=3D -Wno-pointer-sign -Wno-constant-conversion = -Wno-format \ >>> + -Wno-shift-count-negative -Wno-tautological-pointer-compare \ >>> + -Wno-shift-count-overflow -Wno-tautological-compare >>> +.endif >>> + >>> CFLAGS+=3D ${CFLAGS.${COMPILER_TYPE}} >>=20 >> Note that for x86, all of these warnings were already either fixed or >> suppressed. I assume this will be fleshed out later? >=20 > Yea, but since a build universe wasn=92t done, they were present in = the > build. They are harmless on other architectures. >=20 >>> +# Tell bmake not to mistake standard targets for things to be = searched for >>> +# or expect to ever be up-to-date. >>> +PHONY_NOTMAIN =3D afterdepend afterinstall all beforedepend = beforeinstall \ >>> + beforelinking build build-tools buildfiles buildincludes = \ >>> + checkdpadd clean cleandepend cleandir cleanobj configure = \ >>> + depend dependall distclean distribute exe \ >>> + html includes install installfiles installincludes lint = \ >>> + obj objlink objs objwarn realall realdepend \ >>> + realinstall regress subdir-all subdir-depend = subdir-install \ >>> + tags whereobj >>> + >>> +.PHONY: ${PHONY_NOTMAIN} >>> +.NOTMAIN: ${PHONY_NOTMAIN} >>>=20 >>=20 >> Was this latter part intentional? It does not seem to have anything = to >> do with clang at all. >=20 > It was the only bit of bsd.sys.mk that was needed. Unfortunately that broke the build on all architectures where = bce is built as -std=3D was not being passed to the compiler. Jenkins = reported an error with bce: = https://jenkins.freebsd.org/job/FreeBSD_HEAD_sparc64/225/changes , and I = committed a change to bring back that support here: = https://svnweb.freebsd.org/changeset/base/276493 . Please revert it if = it wasn=92t correct. Thanks! --Apple-Mail=_954921B5-610B-4E89-A6FF-453E862FCFC8 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUpMn7AAoJEMZr5QU6S73eG/sH/3lFGhtQgHR1824vXMXDa2W2 lbvycp+YImJdTKur+PafVHVrxIJJG3NxXq1M+Jw4AJdrhGbgGmY8ylpd6UudVdGM lf2u6cPi4VPJ/DUC4RTImbqU/SyQBm3x99FIGoD1HTRHlkZf7NzZ4liRuhgxi45e 9T12sP0EQbAn0ed0CnHFHkynIhIBI6/2nrV9kZlXBfnda0TJxMOxdbTnI5wT0APJ hmn/y3IRsWlQoUlhOQ02rNuesu1S40ykiRSPnO5MDUYYXH7ZDl0Pxo8sJMpJ2UGI RZyBgjO74kPgqfNW55+gIFmUkehtWKeZ6ON5P+fcENcQuT/eV4w2EOvshjzK64w= =5jya -----END PGP SIGNATURE----- --Apple-Mail=_954921B5-610B-4E89-A6FF-453E862FCFC8--