From owner-freebsd-current Mon May 4 10:22:21 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA10894 for freebsd-current-outgoing; Mon, 4 May 1998 10:22:21 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from dyson.iquest.net (dyson.iquest.net [198.70.144.127]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA10692; Mon, 4 May 1998 10:22:02 -0700 (PDT) (envelope-from toor@dyson.iquest.net) Received: (from root@localhost) by dyson.iquest.net (8.8.8/8.8.8) id MAA00588; Mon, 4 May 1998 12:21:58 -0500 (EST) (envelope-from toor) Message-Id: <199805041721.MAA00588@dyson.iquest.net> Subject: Re: cvs commit: src/sys/kern sysv_shm.c src/sys/vm swap_pager.c vm_fault.c vm_map.c In-Reply-To: from dave adkins at "May 4, 98 12:07:33 pm" To: adkin003@tc.umn.edu (dave adkins) Date: Mon, 4 May 1998 12:21:58 -0500 (EST) Cc: dyson@FreeBSD.ORG, adkin003@tc.umn.edu, freebsd-current@FreeBSD.ORG From: "John S. Dyson" Reply-To: dyson@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL38 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG dave adkins said: > > > On Mon, 4 May 1998, John S. Dyson wrote: > > > What you are seeing is a "DIAGNOSTIC" panic that really isn't > > indicating a problem. I am reworking the issue, but for now, just > > disable diagnostic. I'll be committing a fix in an hour. > > > > John, > > It panics without the DIAGNOSTIC message at the line: > > if ((robject->handle == NULL) && > (robject->type == OBJT_DEFAULT || > robject->type == OBJT_SWAP)) { > > trying to derefence robject->handle. > > I put in an additional test to prevent the dereference through NULL: > > if ( robject && (robject->handle == NULL) && > (robject->type == OBJT_DEFAULT || > robject->type == OBJT_SWAP)) { > > > and have been running with it for a few hours. I know its not a real fix, > just a little more info on where I'm failing. > Cool, I have committed a fix. Your handle idea is good, but I can imagine times that the handle check isn't sufficient (note that the split code can do damage to the shm structure.) Instead of depending on the handle, I have added a flag. You have done good detective work, and -current should be okay as of now. (I still have a softupdates problem, that I broke again, so will be fixing that unrelated problem.) -- John | Never try to teach a pig to sing, dyson@freebsd.org | it just makes you look stupid, jdyson@nc.com | and it irritates the pig. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message