From owner-cvs-all Fri Dec 14 10:43:26 2001 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id B59B837B416; Fri, 14 Dec 2001 10:43:15 -0800 (PST) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id fBEIgpl27538; Fri, 14 Dec 2001 20:42:51 +0200 (EET) (envelope-from ru) Date: Fri, 14 Dec 2001 20:42:51 +0200 From: Ruslan Ermilov To: Mark Murray Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/rm rm.c src/usr.sbin/chown chown.c src/usr.sbin/dev_mkdb dev_mkdb.c Message-ID: <20011214204251.K16945@sunbay.com> References: <20011214202230.C16945@sunbay.com> <200112141839.fBEIdSU03381@grimreaper.grondar.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200112141839.fBEIdSU03381@grimreaper.grondar.org> User-Agent: Mutt/1.3.23i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Dec 14, 2001 at 06:39:26PM +0000, Mark Murray wrote: > > His reasoning was that -Werror and -Wmissing-prototypes causes these > > programs to not compile. This is not true for -CURRENT, that's why > > I asked for backout. > > Whatever logic led to the prototypes being put in is less relevant > than the fact that the prototypes are not inherently incorrect, > and there is no reason to remove them, because they do not break > anything. > OK, the please force-commit, and give a real reason. Still fail to see why main() SHOULD be prototyped. Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message