From owner-freebsd-ports@freebsd.org Thu Aug 9 05:22:20 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E99B71055879 for ; Thu, 9 Aug 2018 05:22:19 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 6B54380D2D for ; Thu, 9 Aug 2018 05:22:19 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 2FD531055878; Thu, 9 Aug 2018 05:22:19 +0000 (UTC) Delivered-To: ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0DFC11055877 for ; Thu, 9 Aug 2018 05:22:19 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 81DB580D28 for ; Thu, 9 Aug 2018 05:22:18 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg1-x536.google.com with SMTP id x5-v6so2173135pgp.7 for ; Wed, 08 Aug 2018 22:22:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:from:to:cc:references:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6n/A5sn5MDVktIeYbkl4o/92/sHGZOJBoJxCkQR60b0=; b=l75vGsvn4RqnJ1tqBV12u4RlEqiKM9TgboHhAH3IrJGK2Hfg5IAKGdrfuV3nKFp6P8 fDGJKbkGE1Kc9VU05Jiw1kW7h1rom3XOwZBLdgZ32kkyuZmYVWq/jxI1bGb0xIC+CS20 MRg4xY+X+OVCyh79fZX+WhwoqiGWoOSCF4tH3zLOT+FDWeEy7petV0yeF3HiRULY6QD/ d2Yd2oDoFkf3I/OYjfWFqSNYjSVrFjy6tqLTyw459TzxuUYn9noPTSGYtxZIc3ZQ+gzK 7KUwGKjdrIzqlxbznEpivccPwz6FHUTdXG5GZ7t04WUx8FBoPebBBgKz9EPRRfYkf+v7 +Ryw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:from:to:cc:references :openpgp:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=6n/A5sn5MDVktIeYbkl4o/92/sHGZOJBoJxCkQR60b0=; b=q0AlZSwuEJZVKVzzVGkkUju5UfDIA6Ke29ZplrRW71ZBYiRPqrvafw9VWL17OJG2R3 xgxyUDA2Zd/eGbJUOIGAy73In+IkfTZBlOS3kG7Hwdz7yjAxrWB5HpCHNSwNr5kxYnOM QptOsnrDjzn2o4O4FkX51y1S420516AadkhUy2zapBiZPYv/mNqNzo85Sp9MLa+u/PcC f4c2Oeec8Frt8Kmhu0CxOprP9cuQhENPj+Cemu4zOZb1xVgqrcIc8q0RcasC0KKlYbCE vedcL6o0p9ohZszsPV9bXHu3fES4IfqexdMMNN/ynYLRW57GxuhBniqRAsV2O1yGNFu9 okqQ== X-Gm-Message-State: AOUpUlH25N8EUedFlyWoOAr9Z/0ue4ygJEnQOIzqky4OB4BQfPQ8TyXE gH0toi115zkIxwuOargdAB4hsDRh X-Google-Smtp-Source: AA+uWPyIiOIqzQ3JOi6hOyRklpe8/KegVfBS67BYfJe8sb09KsF/n0AfoT0MV8Wc+kid7aTWqYZjhQ== X-Received: by 2002:a63:4306:: with SMTP id q6-v6mr624967pga.181.1533792137707; Wed, 08 Aug 2018 22:22:17 -0700 (PDT) Received: from [192.168.1.107] ([103.107.240.136]) by smtp.gmail.com with ESMTPSA id g184-v6sm14789694pgc.22.2018.08.08.22.22.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Aug 2018 22:22:17 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: Blackbox does not compile, diff in here From: Kubilay Kocak To: Erich Dollansky Cc: "ports@freebsd.org" , A.J.Caines@halplant.com References: <20180809102943.3ab85fce.freebsd.ed.lists@sumeritec.com> <20180809130514.1c0a6b22.freebsd.ed.lists@sumeritec.com> <4401a3a6-f760-2a76-3dec-7d1ef1da7be9@FreeBSD.org> Openpgp: preference=signencrypt Message-ID: <031da482-32b5-c7c9-036a-2db9e585577f@FreeBSD.org> Date: Thu, 9 Aug 2018 15:22:12 +1000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <4401a3a6-f760-2a76-3dec-7d1ef1da7be9@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 05:22:20 -0000 On 9/08/2018 3:14 pm, Kubilay Kocak wrote: > On 9/08/2018 3:05 pm, Erich Dollansky wrote: >> Hi, >> >> On Thu, 9 Aug 2018 14:34:17 +1000 >> Kubilay Kocak wrote: >> >>> On 9/08/2018 12:29 pm, Erich Dollansky wrote: >>>> >>>> I do not know if somebody spotted this already. Some casting was >>>> done to the wrong types. >>> >>> This looks like >>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226708 >>> >> yes, it is the same. But why could I compile blackbox without a problem >> up to one or two months ago? Did the compiler to comprehend the problem >> before? > > The bug report doesn't contain system information (freebsd version/arch, > date) so it's not immediately at this stage, but I have reproduced the > error on 12-CURRENT (r336056) and am QA'ing other versions/archs as we > speak. Looks like it's Clang 6, so I'm guessing all reporters are running 12-CURRENT post clang 6 import. See Also: https://clang.debian.net/status.php?version=6.0&key=CXX11_NARROWING > What's the uname -a of the system you are seeing this issue on? Could > you add this information in the bug? > > >> Erich >> >> >>> The first and third chunks below appear to be >>> noise/spurious/unnecessary though. >>> >>>> Erich >>>> >>>> PS I am not experienced in creating diffs for ports. This one was >>>> done in the working directory's lib entry: >>>> >>>> >>>> --- EWMH.cc.180809 2005-01-24 >>>> 15:50:56.000000000 +0800 +++ EWMH.cc 2018-08-09 >>>> 10:10:05.630203000 +0800 @@ -204,7 +204,7 @@ >>>> bool bt::EWMH::readNumberOfDesktops(Window target, >>>> unsigned int* number) const { >>>> unsigned char* data = 0; >>>> - if (getProperty(target, XA_CARDINAL, net_number_of_desktops, >>>> &data)) { >>>> + if (getProperty (target, XA_CARDINAL, net_number_of_desktops, >>>> &data)) { *number = >>>> static_cast(*(reinterpret_cast>>> *>(data))); >>>> @@ -246,8 +246,11 @@ >>>> >>>> >>>> void bt::EWMH::setDesktopViewport(Window target, int x, int y) >>>> const { >>>> + // >>>> + // 09.08.18 ed: the following statement was modified. >>>> + // >>>> const unsigned long viewport[] = >>>> - { static_cast(x), static_cast(y) }; >>>> + { static_cast(x), static_cast>>> long>(y) }; setProperty(target, XA_CARDINAL, net_desktop_viewport, >>>> reinterpret_cast(viewport), >>>> 2); } >>>> @@ -644,8 +647,10 @@ >>>> } >>>> >>>> >>>> -bool bt::EWMH::getProperty(Window target, Atom type, Atom property, >>>> - unsigned char** data) const { >>>> +bool bt::EWMH::getProperty (Window target, Atom type, Atom >>>> property, >>>> + unsigned char ** data) >>>> const { Atom atom_return; >>>> int size; >>>> unsigned long nitems, bytes_left; >>>> _______________________________________________ >>>> freebsd-ports@freebsd.org mailing list >>>> https://lists.freebsd.org/mailman/listinfo/freebsd-ports >>>> To unsubscribe, send any mail to >>>> "freebsd-ports-unsubscribe@freebsd.org" >>> >> >