From owner-freebsd-arch Wed Feb 27 15:57:56 2002 Delivered-To: freebsd-arch@freebsd.org Received: from green.bikeshed.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 583E837B417; Wed, 27 Feb 2002 15:57:46 -0800 (PST) Received: from localhost (green@localhost) by green.bikeshed.org (8.11.6/8.11.6) with ESMTP id g1RNvjY46402; Wed, 27 Feb 2002 18:57:45 -0500 (EST) (envelope-from green@green.bikeshed.org) Message-Id: <200202272357.g1RNvjY46402@green.bikeshed.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Alfred Perlstein Cc: bde@FreeBSD.org, arch@FreeBSD.org Subject: Re: Do we want the _SYS_SYSPROTO_H_ junk? In-Reply-To: Message from Alfred Perlstein of "Wed, 27 Feb 2002 14:53:41 PST." <20020227225341.GX80761@elvis.mu.org> From: "Brian F. Feldman" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 27 Feb 2002 18:57:45 -0500 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Alfred Perlstein wrote: > * Brian Fundakowski Feldman [020227 14:39] wrote: > > Since obviously, by nature, all the code for syscall declarations inside > > #ifdef _SYS_SYSPROTO_H_ is bogus, is it truly useful to use it on new system > > calls, or should we not? I think it's worth having an entry in style(9) for > > system calls, and want to know what should be there regarding this. It > > seems the struct foo_args /* structure members stuff */ *uap; stuff is at > > least also consistent with what is similarly done with vnode operation > > declarations. > > > > What do you think? > > I think there's more important stuff to worry about than this. > > I also find that SYSPROTO helps when making syscall modules but > I'm not sure what you're getting at so I'd apprecciate it if you > held off whatever your plans are for a day. I want to know if, on new code, we should put them. E.g.: #ifndef _SYS_SYSPROTO_H_ struct open_args { char *path; int flags; int mode; }; #endif int open(td, uap) struct thread *td; register struct open_args /* { syscallarg(char *) path; syscallarg(int) flags; syscallarg(int) mode; } */ *uap; { The first part, if ever actually called into existence by sysproto.h not being included, would be bogus. Do we want to keep introducing those? -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org <> bfeldman@tislabs.com \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message