From owner-freebsd-mips@freebsd.org Thu Feb 11 06:27:44 2016 Return-Path: Delivered-To: freebsd-mips@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E0CE7AA5032 for ; Thu, 11 Feb 2016 06:27:43 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AF2BE17F6 for ; Thu, 11 Feb 2016 06:27:43 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-io0-x22c.google.com with SMTP id 9so45558618iom.1 for ; Wed, 10 Feb 2016 22:27:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=LIkcPppl5iMTk928hwx0Hqgzzo2zoMWyHJFsHBpQJss=; b=voA3ZthzJferFgPDj5iyK/CVxyZL82AQhwvsiqC3I8VcqM+qdHvUh73jd96jqau5e1 8Ec8LIanIjBh3CzMiiS6iMYsHEaLPd43SZWhnYzPyi9XjQwnCxn91sOBqbeviE7TTRuC 4SueTk6yTz6JpSPJWZ7GPkDh+PSnNcsIKtn3lt1cvJmkAzARilLI5cpgQicRuklavZz7 uC2uXh8WwWJ81SWKPzdOGN6KrPAoCHSUkRc0V+zRgIFK2laRmwCcQ3Ir+1jLfmswGpXB 4GmCy+VDPOI9OzS8Xy2ZtuA9mqOdoqQ6Z6CHygmN9f3yvtG1BxlkgGZCNSJg5nhRkQFh sixA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=LIkcPppl5iMTk928hwx0Hqgzzo2zoMWyHJFsHBpQJss=; b=jYOQgjD3vArI6wMhj1dspKFZ6oOVfqgg3ua7w7NwlSCmjglU77cxInHdTWUcKvO06D oN0VUrhwwGkD5rC438NjZe3lLNGAjECMBkLeNrDZa0T0TjKKhOmQWSCaGqIxV+50Bxo2 lB4EGCJyPPW8F/xWy27lIjx9X/WQIub5MjF+szSQT3LWIjy4K18O92u4ZeaNz+1+IuPj O5jFyg61lv8Gp5OiZgRVFZ0wZMRtWcBcdGbpmBJANNA/PMfbKdwXOs+2rFyJTBXp2eih JeISn2C/CaTRhxUYF/5pk8McnkkJUzeI1Vl9xg54KdRH/hEXp0w9aPRHrPaEXXUOCWix uwAA== X-Gm-Message-State: AG10YOQFdAlCaGQjw2ihn5wUfo1VZXamWCy0OLqKj8bxGALiEbx4cTFdy+QRKdtIxvvKCgkS+t7lPGu4ndT5uw== MIME-Version: 1.0 X-Received: by 10.107.132.142 with SMTP id o14mr42111742ioi.75.1455172062763; Wed, 10 Feb 2016 22:27:42 -0800 (PST) Received: by 10.36.14.19 with HTTP; Wed, 10 Feb 2016 22:27:42 -0800 (PST) In-Reply-To: <316967.63047.qm@web101710.mail.ssk.yahoo.co.jp> References: <316967.63047.qm@web101710.mail.ssk.yahoo.co.jp> Date: Wed, 10 Feb 2016 22:27:42 -0800 Message-ID: Subject: Re: about if_arge.c From: Adrian Chadd To: Mori Hiroki Cc: "freebsd-mips@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Feb 2016 06:27:44 -0000 heh, good catch! I'll go fix it. -a On 10 February 2016 at 20:41, Mori Hiroki wrote: > I make AR2315 ethercode. I refer if_arge.c and I have idea. > > Current code is here. > > if (sc->arge_hw_flags & ARGE_HW_FLG_RX_DESC_ALIGN_4BYTE) > arge_fixup_rx(m); > > m->m_pkthdr.rcvif = ifp; > /* Skip 4 bytes of CRC */ > m->m_pkthdr.len = m->m_len = packet_len - ETHER_CRC_LEN; > > > I think better set m_len before arge_fixup_rx(). > This is only copy packet length at arge_fixup_rx(). > > /* Skip 4 bytes of CRC */ > m->m_pkthdr.len = m->m_len = packet_len - ETHER_CRC_LEN; if (sc->arge_hw_flags & ARGE_HW_FLG_RX_DESC_ALIGN_4BYTE) > arge_fixup_rx(m); > > m->m_pkthdr.rcvif = ifp; > > And > > if (sc->arge_hw_flags & ARGE_HW_FLG_RX_DESC_ALIGN_4BYTE) > m_adj(m, sizeof(uint64_t)); > > I think not need uint64_t(8byte) only tcp header 2 byte(ETHER_ALIGN) shift. > > if (sc->arge_hw_flags & ARGE_HW_FLG_RX_DESC_ALIGN_4BYTE) > m_adj(m, sizeof(uint32_t)); > > Regards. > > Hiroki Mori > > _______________________________________________ > freebsd-mips@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-mips > To unsubscribe, send any mail to "freebsd-mips-unsubscribe@freebsd.org"