Date: Tue, 28 Feb 2017 12:48:31 -0800 From: David Shao <davshao@gmail.com> To: freebsd-x11@freebsd.org Subject: SOLVED i915kms loading problem Re: X11 breaks for Intel after ports update from r433396 -> r433935? Message-ID: <CABZaEK6vsc=T9iiydhULOXuvLcDVfRpV8mX-asfuwdF0VLZVuA@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
Please refer to the following FDO bug report I just made: Bug 100011 - src/intel_device.c reverses return value meaning of xorg server xf86LoadKernelModule() https://bugs.freedesktop.org/show_bug.cgi?id=100011 Short summary from the bug report: "The function load_i915_kernel_module() in file src/intel_device.c of xf86-video-intel reverses the meaning of the return value of xorg server's xf86LoadKernelModule(). xf86LoadKernelModule() actually returns 0 if the loading fails, non-zero if success." Something similar to the following one-line patch can be used: @@ -233,9 +242,8 @@ static int load_i915_kernel_module(void) const char **kn; for (kn = kernel_module_names; *kn; kn++) - if (xf86LoadKernelModule(*kn) == 0) + if (xf86LoadKernelModule(*kn)) return 0; - return -1; } I'm actually using pkgsrc and FreeBSD patches from pkgsrc-wip. Cross-platform can really help debugging.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABZaEK6vsc=T9iiydhULOXuvLcDVfRpV8mX-asfuwdF0VLZVuA>