From owner-freebsd-x11@freebsd.org Tue Feb 28 20:48:33 2017 Return-Path: Delivered-To: freebsd-x11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 50E13CF1B64 for ; Tue, 28 Feb 2017 20:48:33 +0000 (UTC) (envelope-from davshao@gmail.com) Received: from mail-qk0-x233.google.com (mail-qk0-x233.google.com [IPv6:2607:f8b0:400d:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1017F151 for ; Tue, 28 Feb 2017 20:48:33 +0000 (UTC) (envelope-from davshao@gmail.com) Received: by mail-qk0-x233.google.com with SMTP id s186so38077096qkb.1 for ; Tue, 28 Feb 2017 12:48:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=2ltozqsDjmY1n54ca5ZwoltL2CkmBxD0RFGDb/LZKPU=; b=GctQ2AP0yvjwo5BlMV9P2EPqgQOsQnTczCnlETs3xdoGCFJRqFrMeuL/IkRcBNwIKm 63ADAAa5pjyQb5O1gGJiPHnJsr4NzAM1N2xndq4VI+eEwEGCKDeKj5V81GiVhoUA2TQ/ z7DNa4tElGtmF0ZNiDF6wKCb3gRmHUBHWlnQ2TOhvaLHD6Ia3isR4SyGFtLeoj/fjlkT EbTmhzG1aMI7QV0gMvYLFiTsnjRCKYAtUZ3Y/CT7P0SRyYnCEEJSzlnfhs7Xot8jHqAE WxZ5iWq3qjxehWT/BJ/veYkpQBWzv0JqXbohGAmvCf8xvnT0WXU512b2u6X6O3OXmOxm p6eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=2ltozqsDjmY1n54ca5ZwoltL2CkmBxD0RFGDb/LZKPU=; b=gqxEWEPkBp3MB9rxPQhdabwu0lxXP0AX7HT/4DW4omYB8Rkz51o0MRV6DMhoLWV2k1 Ud2a2MRWmjEBirtjhfL9c4eg8P/qfjKFI2Dxzxd1cJj8Wjygehpdw4e9PwOvbcqpbeBt xG+cJS0Ou4meR4em6a88Op2kuMP0nfm/TPa8Z22L3YzBhre445pq4w4jcVxvf5GnHCqj PbBGmIPiM12cI+Q3Be2ZQrn9sFOa6Nj02WWHJdPQTskN5NKSTTgghYcSTjCKNyT9C6Cr n2q1rkAGErJkBBEp5IVxcmdikyE6+AnEXWuplox/91YDD6rmkYdlYgGYMqdw5dzTMY/2 oNsA== X-Gm-Message-State: AMke39kvqjY2nXNuVTya9LohNbmBXlsekvqX2MQD2/h8vmMcIDTwz+7XcYPLDv+52PtyCeLWcUQVrmtnS0oVVQ== X-Received: by 10.55.100.73 with SMTP id y70mr5602537qkb.62.1488314912058; Tue, 28 Feb 2017 12:48:32 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.135.129 with HTTP; Tue, 28 Feb 2017 12:48:31 -0800 (PST) From: David Shao Date: Tue, 28 Feb 2017 12:48:31 -0800 Message-ID: Subject: SOLVED i915kms loading problem Re: X11 breaks for Intel after ports update from r433396 -> r433935? To: freebsd-x11@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 20:48:33 -0000 Please refer to the following FDO bug report I just made: Bug 100011 - src/intel_device.c reverses return value meaning of xorg server xf86LoadKernelModule() https://bugs.freedesktop.org/show_bug.cgi?id=100011 Short summary from the bug report: "The function load_i915_kernel_module() in file src/intel_device.c of xf86-video-intel reverses the meaning of the return value of xorg server's xf86LoadKernelModule(). xf86LoadKernelModule() actually returns 0 if the loading fails, non-zero if success." Something similar to the following one-line patch can be used: @@ -233,9 +242,8 @@ static int load_i915_kernel_module(void) const char **kn; for (kn = kernel_module_names; *kn; kn++) - if (xf86LoadKernelModule(*kn) == 0) + if (xf86LoadKernelModule(*kn)) return 0; - return -1; } I'm actually using pkgsrc and FreeBSD patches from pkgsrc-wip. Cross-platform can really help debugging.