From owner-freebsd-current@FreeBSD.ORG  Fri Jul 13 22:23:45 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 87B5416A400
	for <current@freebsd.org>; Fri, 13 Jul 2007 22:23:45 +0000 (UTC)
	(envelope-from asmrookie@gmail.com)
Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.175])
	by mx1.freebsd.org (Postfix) with ESMTP id 1964E13C4A5
	for <current@freebsd.org>; Fri, 13 Jul 2007 22:23:44 +0000 (UTC)
	(envelope-from asmrookie@gmail.com)
Received: by ug-out-1314.google.com with SMTP id o4so734635uge
	for <current@freebsd.org>; Fri, 13 Jul 2007 15:23:40 -0700 (PDT)
DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta;
	h=domainkey-signature:received:received:message-id:date:from:reply-to:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:sender;
	b=EF0gQWeDF3K5Si33fUPIL9ML81foBUQk7LrajIap4HvgK94BNlKTqGdvC7IL7B9i3cQbuQA0Kvtp1/WcakargM8/FuNnGPMswBVfpacT6BVc5dZZ7MEsXLZGeihVM4Kn/XoNXYpfSpeZcE9cIg4AwUXO/Y44mfg/rsfqGCJIzbQ=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta;
	h=received:message-id:date:from:reply-to:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:sender;
	b=MSB0VAyIrGzlQKEwl1Hc6jQ88yzTekDG/j0EGsZ5mCXNOz2qStk7NAOHuW295p2dZJQFHJIEpdaULrcaz+tb/YSYi76v8nGGeg05QGp7sH3NjCUNliQUdAf0AAWyd1yY+tmb/JSneVjrR/GZS32KL0LGaQjkZCvHCfwRUykAbJU=
Received: by 10.66.243.4 with SMTP id q4mr2314044ugh.1184365420412;
	Fri, 13 Jul 2007 15:23:40 -0700 (PDT)
Received: from ?151.75.219.248? ( [151.75.219.248])
	by mx.google.com with ESMTPS id o56sm84639uga.2007.07.13.15.23.39
	(version=TLSv1/SSLv3 cipher=RC4-MD5);
	Fri, 13 Jul 2007 15:23:40 -0700 (PDT)
Message-ID: <4697FB3F.9030802@FreeBSD.org>
Date: Sat, 14 Jul 2007 00:22:55 +0200
From: Attilio Rao <attilio@FreeBSD.org>
User-Agent: Thunderbird 1.5 (X11/20060526)
MIME-Version: 1.0
To: "M. Warner Losh" <imp@bsdimp.com>
References: <46970DF7.3000803@elischer.org>	<46972B28.1010409@FreeBSD.org>
	<20070713.161145.1324584079.imp@bsdimp.com>
In-Reply-To: <20070713.161145.1324584079.imp@bsdimp.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: Attilio Rao <asmrookie@gmail.com>
Cc: julian@elischer.org, current@FreeBSD.org
Subject: Re: crash in tty code in 6.1.. fixed since?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: attilio@FreeBSD.org
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jul 2007 22:23:45 -0000

M. Warner Losh wrote:
> In message: <46972B28.1010409@FreeBSD.org>
>             Attilio Rao <attilio@FreeBSD.org> writes:
> : I think it has been fixed some months ago IIRC.
> : The problem here, should be that if sx_slock() let thread sleep, Giant 
> : is released before to sleep and tp->t_session can be accessed in racy way.
> : Another nice side-effect about having tty Giant :)
> 
> I've been having crashes right and left in cblock code.  I've had good
> luck converting it to using a mutext.  However, someone else was
> telling me they had big problems going all the way and locking the
> entire TTY subsystem.  The evidence is in p4...

What depot do you refer exactly?

Attilio