From owner-cvs-all@FreeBSD.ORG Fri Feb 16 07:34:41 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EB98816A401; Fri, 16 Feb 2007 07:34:41 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 9990F13C494; Fri, 16 Feb 2007 07:34:41 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 0ECEA47377; Fri, 16 Feb 2007 02:34:41 -0500 (EST) Date: Fri, 16 Feb 2007 07:34:40 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Pawel Jakub Dawidek In-Reply-To: <20070216073206.C83539@fledge.watson.org> Message-ID: <20070216073405.B83539@fledge.watson.org> References: <200702152208.l1FM8aY7002188@repoman.freebsd.org> <20070216073206.C83539@fledge.watson.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/hpfs hpfs_vfsops.c hpfs_vnops.c src/sys/fs/msdosfs msdosfs_vfsops.c msdosfs_vnops.c src/sys/fs/ntfs ntfs_vfsops.c ntfs_vnops.c src/sys/fs/nullfs null_vfsops.c null_vnops.c src/sys/fs/udf udf.h udf_vfsops.c ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Feb 2007 07:34:42 -0000 On Fri, 16 Feb 2007, Robert Watson wrote: > On Thu, 15 Feb 2007, Pawel Jakub Dawidek wrote: > >> Move vnode-to-file-handle translation from vfs_vptofh to vop_vptofh >> method. >> This way we may support multiple structures in v_data vnode field within >> one file system without using black magic. >> >> Vnode-to-file-handle should be VOP in the first place, but was made VFS >> operation to keep interface as compatible as possible with SUN's VFS. >> BTW. Now Solaris also implements vnode-to-file-handle as VOP operation. >> >> VFS_VPTOFH() was left for API backward compatibility, but is marked for >> removal before 8.0-RELEASE. >> >> Approved by: mckusick >> Discussed with: many (on IRC) >> Tested with: ufs, msdosfs, cd9660, nullfs and zfs > > Do you think API backward compatibility is actually required in 7.x? It > looks like you've updated all the file systems, in which case the temptation > would be to drop it as we already have other VFS changes in 7.x from 6.x. Also, you probably need to do something about the VFS_FHTOVP(9) man page for completeness. Robert N M Watson Computer Laboratory University of Cambridge