From owner-freebsd-current@FreeBSD.ORG Mon Oct 8 07:33:01 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 45FD316A417 for ; Mon, 8 Oct 2007 07:33:01 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.181]) by mx1.freebsd.org (Postfix) with ESMTP id B3FC513C447 for ; Mon, 8 Oct 2007 07:33:00 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by wa-out-1112.google.com with SMTP id k17so1609455waf for ; Mon, 08 Oct 2007 00:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; bh=6R9e+Ej9lMcRYO96RcL8NNltjQzonAKBtlGrPqGTLrA=; b=EZqAlUwpIrRbdNl6ZKKpzt1HW2+sUg9sgz+ew1UDrjunyydn6cR55ysd4DYXRjV/WxJnyFrJNZgfr7weSjWtk2G5/r/x0MJ3qdlemaq9OB8cznTdo67agUHs9XaxE+FMwhK1LDb1621o0PpbP61wQvCnz0J1xLIybHfTIXwoOxg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=aI5JTN1Qq4hqCWqXmmhOEVAjarJQTTxddlYQeY52wSpwtHhHm+Qm/20I0OvOp868gupDum6Sb+ytOqJ9lOiSkI2IcJljVztgW/4T5KJLlg8F7JE5/V69l+j7o7ACelMchwRggXAEljv7xSqeenJ69DIH1lkzxs1UTwAhW79ehmU= Received: by 10.114.199.1 with SMTP id w1mr429276waf.1191828779419; Mon, 08 Oct 2007 00:32:59 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTPS id k24sm11791357waf.2007.10.08.00.32.54 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 08 Oct 2007 00:32:58 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id l987TCPn048191 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 8 Oct 2007 16:29:12 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id l987TBBw048190; Mon, 8 Oct 2007 16:29:11 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Mon, 8 Oct 2007 16:29:11 +0900 From: Pyun YongHyeon To: "Bjoern A. Zeeb" Message-ID: <20071008072911.GG46694@cdnetworks.co.kr> References: <20071008061758.GF46694@cdnetworks.co.kr> <20071008070345.E6043@maildrop.int.zabbadoz.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071008070345.E6043@maildrop.int.zabbadoz.net> User-Agent: Mutt/1.4.2.1i Cc: freebsd-current@FreeBSD.org Subject: Re: CFT: vr(4) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2007 07:33:01 -0000 On Mon, Oct 08, 2007 at 07:04:32AM +0000, Bjoern A. Zeeb wrote: > On Mon, 8 Oct 2007, Pyun YongHyeon wrote: > > >It seems that there had been several stability issues in vr(4). > >Here is mimimal patch that make vr(4) work reliably under heavy > >network loads. The patch does the following: > >- Always check writability of mbuf before padding and make a > > writable copy of the mbuf if mbuf is marked as read-only. > >- Before padding is done check remaining bytes such that it can > > safely extend buffer size of the mbuf. > >- Before padding always check the return value of m_defrag(9). > >- Zero out pad space to avoid leaking data. > > > >If you have vr(4) hardware please give it spin and let me know > >the result. > > Had you seen wpaul's posting to net@ a few weeks ago. That had a patch > attached as well. What about that? > Yep, and I also asked for testing a patch for the issue. He said testing the patch would take a while and I'm still waiting for the result. http://lists.freebsd.org/pipermail/freebsd-current/2007-August/076495.html -- Regards, Pyun YongHyeon