From owner-svn-src-head@freebsd.org Mon Oct 10 17:21:27 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A41BDC0C490; Mon, 10 Oct 2016 17:21:27 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io0-f178.google.com (mail-io0-f178.google.com [209.85.223.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 183D29BD; Mon, 10 Oct 2016 17:21:27 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io0-f178.google.com with SMTP id q192so118049441iod.0; Mon, 10 Oct 2016 10:21:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=bwVek/zWoj0aofDu1oUriTo7k0+aXhV9rSr2/roD5wQ=; b=eq5Moq99018jnGkYEKHjDoNzGb2T2T2iyIPLb/KWqLU0I7+ZHQJW1grdR8yIRyduwh OTM3HJz2RS9kGMfgIiOVOPnBq42WlOFlcTq4w9KcbAHvyOsKxs66a0ln65/EsoJ3kpFU tVw7Jxl/z6jH2UjGknl85b9/kAdVrGebKhd51OCfm7EZKstIGa7TODh21efAzi6pqRFi bi28J5qfWlDk1TUDMMUV2Gb4mLqQ2r3424y+iJXyJUMiephqkU4f9vS9Icv/GEsVeUeR jSUMOqVS8TV8eVd7jP6nDHJIp7Wwx2K2OHbog++FlrRLOeQJaMUSOCLtXcYsuVoZ0BfS WV8A== X-Gm-Message-State: AA6/9RnTu3TWH4mFD8qXOUeVtJlJWpdgFlXoEUU4Ht3PGRFaNK6M1ZyIqGTeyVrbbMv4vQ== X-Received: by 10.107.130.16 with SMTP id e16mr34003298iod.38.1476120080414; Mon, 10 Oct 2016 10:21:20 -0700 (PDT) Received: from mail-io0-f182.google.com (mail-io0-f182.google.com. [209.85.223.182]) by smtp.gmail.com with ESMTPSA id e69sm4619909iod.39.2016.10.10.10.21.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Oct 2016 10:21:20 -0700 (PDT) Received: by mail-io0-f182.google.com with SMTP id q192so118049075iod.0; Mon, 10 Oct 2016 10:21:19 -0700 (PDT) X-Received: by 10.107.168.96 with SMTP id r93mr32589024ioe.31.1476120079707; Mon, 10 Oct 2016 10:21:19 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.36.220.129 with HTTP; Mon, 10 Oct 2016 10:21:19 -0700 (PDT) In-Reply-To: <20161010165038.GA31246@bsdpad.com> References: <201610101340.u9ADe5XW093068@repo.freebsd.org> <20161010165038.GA31246@bsdpad.com> From: Conrad Meyer Date: Mon, 10 Oct 2016 10:21:19 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r306962 - head/tests/sys/kern/pipe To: Ruslan Bukin Cc: Ruslan Bukin , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2016 17:21:27 -0000 On Mon, Oct 10, 2016 at 9:50 AM, Ruslan Bukin wrote: > On Mon, Oct 10, 2016 at 08:04:44AM -0700, Conrad Meyer wrote: >> We also observed this test was broken, but I think the right fix is >> much smaller: >> >> --- a/tests/sys/kern/pipe/pipe_fstat_bug_test.c >> +++ b/tests/sys/kern/pipe/pipe_fstat_bug_test.c >> @@ -108,7 +108,6 @@ main(void) >> SYNC_W(0, go2); >> >> SYNC_R(0, go); >> - SYNC_W(0, go2); /* XXX: why is this required? */ >> WRITE(8192); >> SYNC_W(0, go2); >> >> (That line breaks the synchronization mechanism that is the only >> guarantee the test passes.) > > There is some direct mode activated when you send >=8192, > so this line is required Given that line breaks the parent-child synchronization entirely and your kevent replaces it, why not remove the remaining go/go2 pipe and read/writes? Best, Conrad