Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 5 Apr 2007 22:29:47 +0930 (CST)
From:      Benjamin Close <benjsc@FreeBSD.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/111270: [patch] wmnd does not work on amd64
Message-ID:  <200704051259.l35Cxl4I066299@pegasus.clearchain.com>
Resent-Message-ID: <200704051320.l35DK6E5016406@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         111270
>Category:       ports
>Synopsis:       [patch] wmnd does not work on amd64
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Apr 05 13:20:05 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Benjamin Close
>Release:        FreeBSD 6.2-RELEASE i386
>Organization:
>Environment:
System: FreeBSD pegasus.clearchain.com 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Tue Jan 16 10:32:48 CST 2007 benjsc@pegasus.clearchain.com:/usr/obj/usr/src/sys/PEGASUS i386


>Description:
	The wmnd port uses an int when querying the network devices via sysctl(3).
	Under amd64, this causes a failure of sysctl due to the size of the int and hence
	no network devices are detected.  The fix is simply to use the correct data type: size_t;

>How-To-Repeat:
	Run the port on amd64
>Fix:
	The below patch fixes the problem and provides everything required to update the port


Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/net/wmnd/Makefile,v
retrieving revision 1.17
diff -u -r1.17 Makefile
--- Makefile	5 Nov 2006 07:53:16 -0000	1.17
+++ Makefile	5 Apr 2007 12:47:31 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	wmnd
 PORTVERSION=	0.4.12
+PORTREVISION=  1
 CATEGORIES=	net
 MASTER_SITES=	http://www.yuv.info/wmnd/releases/
 
Index: files/patch-src-drivers.c
===================================================================
RCS file: files/patch-src-drivers.c
diff -N files/patch-src-drivers.c
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/patch-src-drivers.c	5 Apr 2007 12:40:06 -0000
@@ -0,0 +1,21 @@
+--- src/drivers.c	Thu Apr 20 23:51:30 2006
++++ ../wmnd-0.4.12-p/src/drivers.c	Thu Apr  5 22:05:34 2007
+@@ -570,7 +570,8 @@
+   struct freebsd_sysctl_drvdata* drdata;
+   int numifaces, numrfaces = 0;
+   int mib[5], datamib[6];
+-  int i, len, len2;
++  int i; 
++  size_t len, len2;
+ 
+   mib[0] = CTL_NET;
+   mib[1] = PF_LINK;
+@@ -636,7 +637,7 @@
+ {
+   struct freebsd_sysctl_drvdata* drdata = dev->drvdata;
+   int datamib[6];
+-  int len;
++  size_t len;
+ 
+   *ip = *op = *ib = *ob = 0;
+ 
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200704051259.l35Cxl4I066299>