From owner-freebsd-net@FreeBSD.ORG  Fri Oct 15 07:20:40 2004
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id AC89316A4CE; Fri, 15 Oct 2004 07:20:40 +0000 (GMT)
Received: from cell.sick.ru (cell.sick.ru [217.72.144.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D1E7A43D46; Fri, 15 Oct 2004 07:20:39 +0000 (GMT)
	(envelope-from glebius@freebsd.org)
Received: from cell.sick.ru (glebius@localhost [127.0.0.1])
	by cell.sick.ru (8.12.11/8.12.8) with ESMTP id i9F7Kb1c053227
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 15 Oct 2004 11:20:37 +0400 (MSD)
	(envelope-from glebius@freebsd.org)
Received: (from glebius@localhost)
	by cell.sick.ru (8.12.11/8.12.11/Submit) id i9F7Kb7W053226;
	Fri, 15 Oct 2004 11:20:37 +0400 (MSD)
	(envelope-from glebius@freebsd.org)
X-Authentication-Warning: cell.sick.ru: glebius set sender to
	glebius@freebsd.org using -f
Date: Fri, 15 Oct 2004 11:20:37 +0400
From: Gleb Smirnoff <glebius@freebsd.org>
To: Andre Oppermann <andre@freebsd.org>
Message-ID: <20041015072037.GB53159@cell.sick.ru>
References: <20041014174225.GB49508@cell.sick.ru>
	<416EBF0A.CB1C0366@networx.ch> <20041014202305.GA50360@cell.sick.ru>
	<416EE620.186AD27A@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <416EE620.186AD27A@freebsd.org>
User-Agent: Mutt/1.5.6i
cc: net@freebsd.org
Subject: Re: small tun(4) improvement
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Oct 2004 07:20:40 -0000

On Thu, Oct 14, 2004 at 10:48:32PM +0200, Andre Oppermann wrote:
A> > We are going to have triple cut'n'paste: if_tun.c, ng_device.c, if_tap.c.
A> > What about m_uiocopy()? The question is where can we put this function?
A> 
A> What about the existing m_uiotombuf() function in kern/uipc_mbuf.c?

Damn, I'm blind. :) Investigated libmchain, but missed this.

A> > P.P.S. BTW, ng_eiface+ng_device is going to supersede tap(4), same way as
A> > ng_iface+ng_device is going to supersede tun(4).  :)
A> 
A> Yes and no.  While the netgraph equivalents may have the same functionality
A> we want to keep the existing and well-known API's to keep porting easier.
A> On top of that there is nothing wrong with tap(4) and tun(4) (except the
A> mbuf inefficiency you are about to fix).

I didn't meant that we will remove tun(4) and tap(4). I meant that we can
patch their consumers to alternatively use ng_iface.

-- 
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE