From owner-svn-src-all@FreeBSD.ORG Thu May 5 13:13:22 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 23936106566B; Thu, 5 May 2011 13:13:22 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id B98768FC13; Thu, 5 May 2011 13:13:21 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 70E9145EA7; Thu, 5 May 2011 15:13:17 +0200 (CEST) Received: from localhost (public-gprs14895.centertel.pl [87.96.58.47]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 77AF545684; Thu, 5 May 2011 15:13:09 +0200 (CEST) Date: Thu, 5 May 2011 15:12:43 +0200 From: Pawel Jakub Dawidek To: "Andrey V. Elsukov" Message-ID: <20110505131242.GC14661@garage.freebsd.pl> References: <201105041806.p44I6edT061463@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TYecfFk8j8mZq+dy" Content-Disposition: inline In-Reply-To: <201105041806.p44I6edT061463@svn.freebsd.org> X-OS: FreeBSD 9.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-2.6 required=4.5 tests=BAYES_00 autolearn=ham version=3.0.4 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r221449 - head/sys/geom/journal X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2011 13:13:22 -0000 --TYecfFk8j8mZq+dy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 04, 2011 at 06:06:40PM +0000, Andrey V. Elsukov wrote: > Author: ae > Date: Wed May 4 18:06:40 2011 > New Revision: 221449 > URL: http://svn.freebsd.org/changeset/base/221449 >=20 > Log: > Removed KASSERT, g_new_providerf() can not fail. Well, the assertion was there to prepare us for times when g_new_providerf() will be able to fail. I was suspecting we might want to make g_new_providerf() to fail when the given name is already in use. In such case we use to create two identical entries in /dev/, not sure what we do now (panic?). > Modified: > head/sys/geom/journal/g_journal.c >=20 > Modified: head/sys/geom/journal/g_journal.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/geom/journal/g_journal.c Wed May 4 17:58:15 2011 (r221448) > +++ head/sys/geom/journal/g_journal.c Wed May 4 18:06:40 2011 (r221449) > @@ -2097,7 +2097,6 @@ g_journal_worker(void *arg) > gp =3D sc->sc_geom; > g_topology_lock(); > pp =3D g_new_providerf(gp, "%s.journal", sc->sc_name); > - KASSERT(pp !=3D NULL, ("Cannot create %s.journal.", sc->sc_name)); > pp->mediasize =3D sc->sc_mediasize; > /* > * There could be a problem when data provider and journal providers --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --TYecfFk8j8mZq+dy Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk3CokoACgkQForvXbEpPzT5ogCfWqb2IW6BXrsddEg9DjDZzapA bGkAnjZiOhJL4t2TWFyS39p0NGOZfW/h =B+bh -----END PGP SIGNATURE----- --TYecfFk8j8mZq+dy--