From owner-svn-src-head@freebsd.org Fri Jul 6 00:20:35 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8FF351043A05; Fri, 6 Jul 2018 00:20:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 386377E2DE; Fri, 6 Jul 2018 00:20:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-2.local (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 1526C10AFD2; Thu, 5 Jul 2018 20:20:32 -0400 (EDT) Subject: Re: svn commit: r335916 - head/sys/conf To: Eugene Grosbein , Konstantin Belousov References: <201807032305.w63N5guY063293@repo.freebsd.org> <20180704142233.GB5562@kib.kiev.ua> <6e5bc5e4-052c-877f-1c36-c72e276ff045@FreeBSD.org> <20180705155417.GI5562@kib.kiev.ua> <2a5b1c50-0f50-bbe1-4fcd-b98f61d24571@FreeBSD.org> <5B3EA725.4010202@grosbein.net> <1dd03d43-6f0d-580b-fd3b-f4494da42c70@FreeBSD.org> <5B3EB443.50004@grosbein.net> Cc: Matt Macy , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: John Baldwin Message-ID: Date: Thu, 5 Jul 2018 17:20:32 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <5B3EB443.50004@grosbein.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Thu, 05 Jul 2018 20:20:33 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 00:20:35 -0000 On 7/5/18 5:13 PM, Eugene Grosbein wrote: > 06.07.2018 6:59, John Baldwin wrote: > >>> I'm not sure I understand the topic quite right, but please do not drop >>> MODULES_WITH_WORLD support at it allows us to quickly rebuild the kernel >>> in case of slight changes of its config file not changing ABI and/or >>> similar source changes without HUGE modules compilation overhead. >> >> This would not drop it, but it would mean that you can't necessarily kldload >> /boot/kernel.GENERIC/foo.ko while running some other kernel. > > And what's profit of such restriction? There were several cases > when I was forced to extract somemodule.ko from FreeBSD distribution files > and upload it to some customized installation such as FreeNAS or NAS4Free > or another one running custom kernel and having stripped-down module set out-of-the-box. > For example, ichwd.ko or something like that. And I was just happy I could do that and > that just work. Why should we break it? You would still do that by 'cd /sys/modules/foo; make; scp foo.ko somebox:' The profit of the restriction is performance. Making kernel modules generic makes them slower by forcing them to indirect certain lightweight operations through function calls that the kernel itself performs inline (and "tied" modules would inline these same things). The other benefit is that providing a convenient way to recompile modules from ports would alleviate KBI breakage for ports such as nvidia-graphics and virtualbox-ose-kmod that can break since they use parts of the kernel for which we do not guarantee KBI stability. -- John Baldwin