Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Sep 2003 12:48:06 +0800
From:      "Kang Liu" <liukang@bjpu.edu.cn>
To:        <FreeBSD-gnats-submit@FreeBSD.org>
Cc:        'Ernst de Haan' <znerd@FreeBSD.org>
Subject:   ports/57234: [maintainer]Fix pkg permission and master_sites problem in jakarta-tomcat5
Message-ID:  <000701c383e9$613b22f0$e04e70ca@lkatschool>
Resent-Message-ID: <200309260500.h8Q50M7E071502@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         57234
>Category:       ports
>Synopsis:       [maintainer]Fix pkg permission and master_sites problem in jakarta-tomcat5
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 25 22:00:22 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Kang Liu
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
Beijing University of Technology
>Environment:
System: FreeBSD ipfwtest.frontfree.net 5.1-CURRENT FreeBSD 5.1-CURRENT #16: Wed Sep 17 20:33:30 CST 2003
root@ipfwtest.frontfree.net:/usr/obj/usr/src/sys/IPFW i386
>Description:
1.As Angelo Turetta said in freebsd-ports, when use pkg_add to install jakarta-tomcatX, the permission of directory is not correct.
2 when use portlint checking jakarta-tomcat5, it said I should add a "/" in the end of MASTER_SITES

>How-To-Repeat:
1.make package and pkg_add it. see stdout.log for details.
2. run portlint
>Fix:
In my patch:
1. Add "/" to the end of MASTER_SITES
2. Add "chown" into pkg-plist to slove pkg_add permission problem.
3. Dump PORTREVISION

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/www/jakarta-tomcat5/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- Makefile	25 Sep 2003 08:59:31 -0000	1.3
+++ Makefile	26 Sep 2003 04:35:15 -0000
@@ -7,9 +7,10 @@
 
 PORTNAME=	jakarta-tomcat
 PORTVERSION=	5.0.12
+PORTREVISION=	1
 CATEGORIES=	www java
 MASTER_SITES=	http://www.apache.org/dist/jakarta/tomcat-5/v${PORTVERSION}-beta/bin/ \
-		http://apache.lemon4ssc.org/dist/jakarta/tomcat-5/v{PORTVERSION}-beta/bin \
+		http://apache.lemon4ssc.org/dist/jakarta/tomcat-5/v{PORTVERSION}-beta/bin/ \
 		http://distfiles.coredump.cn/
 
 MAINTAINER=	liukang@bjpu.edu.cn
@@ -22,7 +23,6 @@
 WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
 APP_HOME?=	${PREFIX}/${PKGBASE}${PORTVERSION:R}
 LOG_DIR=	${APP_HOME}/logs
-PLIST_SUB+=	T=${APP_HOME:S/^${PREFIX}\///}
 APP_TITLE=	Jakarta Tomcat
 APP_SHORTNAME=	tomcat${MAJOR_VER:S/.//}
 CONTROL_SCRIPT_NAME=	${APP_SHORTNAME}ctl
@@ -49,7 +49,7 @@
 		${WRKSRC}/conf/server.xml
 JAR_FILE=	bin/bootstrap.jar
 WRKDIR?=	${WRKDIRPREFIX}${.CURDIR}/work
-
+PLIST_SUB+=     T=${APP_HOME:S/^${PREFIX}\///} WWWOWN=${USER} WWWGRP=${GROUP}
 .include <bsd.port.pre.mk>
 
 pre-patch:
Index: pkg-plist
===================================================================
RCS file: /home/ncvs/ports/www/jakarta-tomcat5/pkg-plist,v
retrieving revision 1.3
diff -u -r1.3 pkg-plist
--- pkg-plist	25 Sep 2003 08:59:31 -0000	1.3
+++ pkg-plist	26 Sep 2003 04:35:42 -0000
@@ -1684,6 +1684,8 @@
 %%T%%/webapps/tomcat-docs/ssl-howto.html
 %%T%%/webapps/tomcat-docs/status.html
 @exec mkdir %D/%%T%%/work || true
+@exec mkdir %D/%%T%%/common/classes ||true
+@exec chown -R %%WWWOWN%%:%%WWWGRP%% /usr/local/jakarta-tomcat5.0
 @dirrm %%T%%/work
 @dirrm %%T%%/webapps/tomcat-docs/servletapi/resources
 @dirrm %%T%%/webapps/tomcat-docs/servletapi/javax/servlet/http/class-use

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?000701c383e9$613b22f0$e04e70ca>