From owner-svn-src-all@FreeBSD.ORG Thu Dec 25 21:17:56 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 63F89D64 for ; Thu, 25 Dec 2014 21:17:56 +0000 (UTC) Received: from mail-qc0-f171.google.com (mail-qc0-f171.google.com [209.85.216.171]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 22A953491 for ; Thu, 25 Dec 2014 21:17:55 +0000 (UTC) Received: by mail-qc0-f171.google.com with SMTP id r5so6819341qcx.2 for ; Thu, 25 Dec 2014 13:17:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=FrDFeI9AsxgBKMjRZlY9m8NxRIzRDGbZWd3onUOSQcU=; b=lbXms9kBADo9q2EQnhwdelyMgmzjCrlxXdvebsCbgcSXntZYy0vjfHEg5nsLlcB6G4 8zegK4lGKJYigr8Nuk2BHgOar2Ce9XzKQdZnJ1ctH6tE32tqz/Sbr5Fz0OLJ4yw7Nqj/ /CF543eR8L2cahJcB0dsq21P7oqhZQb7MX+zsQKyyi7/mtcKNSUiCxAz8ngu8pII51kZ 096d/qIVvOH8Onxq/0+iEuLWjeEBp/cBQuVnZfY+zzQwcI2RyRKaLKn3fhlSCtUx/n3W qoIqJHYAgKf8XaKsfJQaGrrAkliWMk2eyh+evP8y0rxJr4QX+5+Ev8NpS84w5fgjXTsZ qQsw== X-Gm-Message-State: ALoCoQlQUtFXmlFmEPfbkQWqvu8UKFxjynfL+n1Ox3HXdTLrFyJ3CWyiQ4SF32VfV9rNbW1wN57A MIME-Version: 1.0 X-Received: by 10.224.14.66 with SMTP id f2mr54031664qaa.81.1419541840728; Thu, 25 Dec 2014 13:10:40 -0800 (PST) Received: by 10.140.88.103 with HTTP; Thu, 25 Dec 2014 13:10:40 -0800 (PST) In-Reply-To: <201412230931.sBN9VPMK017968@svn.freebsd.org> References: <201412230931.sBN9VPMK017968@svn.freebsd.org> Date: Thu, 25 Dec 2014 15:10:40 -0600 Message-ID: Subject: Re: svn commit: r276123 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs From: Will Andrews To: Steven Hartland Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Dec 2014 21:17:56 -0000 Why was the original condition there? It may not be documented in a commenf, but presumably there is a reason. Did you ask the original author of the code in question? --Will. On Tuesday, December 23, 2014, Steven Hartland wrote: > Author: smh > Date: Tue Dec 23 09:31:24 2014 > New Revision: 276123 > URL: https://svnweb.freebsd.org/changeset/base/276123 > > Log: > Always sync the global ZFS config cache to reflect the new mosconfig > > This fixes out of date zpool.cache for root pools, which can cause issues > such as confusion of zdb etc. > > MFC after: 1 month > > Modified: > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_config.c > > Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_config.c > > ============================================================================== > --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_config.c > Tue Dec 23 08:51:30 2014 (r276122) > +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_config.c > Tue Dec 23 09:31:24 2014 (r276123) > @@ -536,8 +536,7 @@ spa_config_update(spa_t *spa, int what) > /* > * Update the global config cache to reflect the new mosconfig. > */ > - if (!spa->spa_is_root) > - spa_config_sync(spa, B_FALSE, what != > SPA_CONFIG_UPDATE_POOL); > + spa_config_sync(spa, B_FALSE, what != SPA_CONFIG_UPDATE_POOL); > > if (what == SPA_CONFIG_UPDATE_POOL) > spa_config_update(spa, SPA_CONFIG_UPDATE_VDEVS); > >