From nobody Wed Aug 6 15:32:24 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bxvRs076lz63s8K; Wed, 06 Aug 2025 15:32:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bxvRr6YPqz47Nv; Wed, 06 Aug 2025 15:32:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754494344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=g+1zEnnmjyXPOth9OqhNFY8GzgL2BYchUHcsDuwnMQ8=; b=h+wObDFnGI2EiANtF0fN8Sq3y2r4J/wYutOIoFvhOrgQ4eFoaV33lI4g4xO+oAO6OpI1lm ms6Wb00j+ceDCL6IUadLwNAHvysPtMHjDtACOTwYtSMONysPxCqCapBIks1SgBMx/Yqjrp 9ShruONvq7VQcDkwENnB4PusAcDysAdbPIxNFRs20CU3GmE6s0IGq2M/v9o39i7Ly8gQy3 SOwTfYBsrN4riqXC1ihwV8tsUrsKLYy5Na4s7+S2tiLi/wmLxTN6ghqOUgXjRNyDKLVtAj lN5YatRUsg8eSQz+DjnOLqajMvNh9KNawVthRjUwBOCyJCabCXUjWgWoLqIoXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754494344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=g+1zEnnmjyXPOth9OqhNFY8GzgL2BYchUHcsDuwnMQ8=; b=oekfsr8nt1z4XAax2fkJ4FW9qcgB3JWjxgcN4xzitd/ORLif4n9nAkaRMN2EWuHB8fhf4K s3Nubh+q99zymbvRSWcvFbsA8Ye6W0iuWichf+ayiPlEGW+HcPtdMGLY+1uUapASO1WEXW 2PHDq+W8sW1upRBnYwEmxJyaUwENeKZ/v2aG96Gv4mH3MK7DWJh5XAd6oARAurKibOk5a1 +fYKQqD6jnFAS2BPeDbH+ycamJUF6uE84VfkUQ3VEb8XonY5IPYqorUrXWGl8EvSCov8ne 8h0l8aX7TCvRidgQfC3WBfELItI04Cb3GCjElq6n9K5N66eQmehTqgfNqKhw5g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1754494344; a=rsa-sha256; cv=none; b=UvwO2B2HhK34O2HkEaBEg5//no2i7P6t2uwFWtRBrORZVTEehuHLo+tNvLkH5RrzQvTNsH 0b0exX4jNF730YtL1UW3y2SNn13v1eXL4ZP97DP1UbyXlSvdjIBNfm4dEyBSakH2UGHwL9 2vr9sk7U1388gptNusbwZFhM52gG1XwCZp5ddwOq1alAPel/UScB5Q1dOsyBxX9r/uzqus RBDPCvFonztq5mF4njniUcVrjpBHICIfCfCu4RCKByknw1s1s9FosDkVKqDWvf/9CQaCjk WYwrfxM3bbjJkh6nb0fpXl4sBu1+OpmkksqE8mLLwvUkkYmdH3p90l0SkdvRgg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bxvRr68WZzBHX; Wed, 06 Aug 2025 15:32:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 576FWOBx047923; Wed, 6 Aug 2025 15:32:24 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 576FWOJT047920; Wed, 6 Aug 2025 15:32:24 GMT (envelope-from git) Date: Wed, 6 Aug 2025 15:32:24 GMT Message-Id: <202508061532.576FWOJT047920@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling =?utf-8?Q?Sm=C3=B8rgrav?= Subject: git: 627831eba3de - stable/14 - netlink: Fully clear parser state between messages List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 627831eba3deb2644edc2b92c4ce8365321b8930 Auto-Submitted: auto-generated The branch stable/14 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=627831eba3deb2644edc2b92c4ce8365321b8930 commit 627831eba3deb2644edc2b92c4ce8365321b8930 Author: Dag-Erling Smørgrav AuthorDate: 2025-07-31 10:06:47 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2025-08-06 13:52:12 +0000 netlink: Fully clear parser state between messages Failing to reset the cookie between messages can lead to an attempt to interpret a zeroed buffer as a struct nlattr, causing a length calculation to underflow, resulting in a memcpy() call where the length exceeds the actual size of the buffer. MFC after: 1 week PR: 283797 Reviewed by: glebius Differential Revision: https://reviews.freebsd.org/D51634 (cherry picked from commit a8d90e32133b77a49c2551f22e59f72d65293b64) --- sys/netlink/netlink_io.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/netlink/netlink_io.c b/sys/netlink/netlink_io.c index 0ca71fb6219b..c6827c76c623 100644 --- a/sys/netlink/netlink_io.c +++ b/sys/netlink/netlink_io.c @@ -520,6 +520,7 @@ static void npt_clear(struct nl_pstate *npt) { lb_clear(&npt->lb); + npt->cookie = NULL; npt->error = 0; npt->err_msg = NULL; npt->err_off = 0;