From owner-freebsd-arch@FreeBSD.ORG Fri Apr 17 13:54:11 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1500A484 for ; Fri, 17 Apr 2015 13:54:11 +0000 (UTC) Received: from mail-pd0-f174.google.com (mail-pd0-f174.google.com [209.85.192.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DAA8C5FF for ; Fri, 17 Apr 2015 13:54:10 +0000 (UTC) Received: by pdbqa5 with SMTP id qa5so128890656pdb.1 for ; Fri, 17 Apr 2015 06:54:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=I2elQfI5+457SrwryEZjFX9fAB16PSS7pmrnekKIgbU=; b=PqwAY1cNAciCTzst2mIhmf41bzN6Vya1gJ++Q8rNoTIk5ajK/kKuhHJ8/9uO4cL3A7 8ETSP0EW1J3+FhAPySpVOL7OY6tYcOQIUZdbVfRP72GYjXsSkqZkCPVEoa4GA+odH1kj XlB7LXkyM/PkeKH3V+b1GWqcN6y+JP8ZduAcAAO6NRUq1E/RT2ra5kpTPm0KRpHtj63B KcP0dlfbp5IBq8ZCfFPtSlGxqepcNf5okL9+b1LL8iDS+PbdyqWFJMsANQw2Jz+QUcm/ JXWLI3Pmqdsbn37D7o/1icQDjcJBLw919SwQj0j1bXJ9L8Y69NlUQNyIm4ZvnJFOie2j o8aQ== X-Gm-Message-State: ALoCoQmjg12uUSxjxomjLACeGGyta6onD28CgQfwh0pLn341Zb94CAbF8u3viAiWonnxWVLXo7Ub X-Received: by 10.66.162.165 with SMTP id yb5mr2767832pab.32.1429278844565; Fri, 17 Apr 2015 06:54:04 -0700 (PDT) Received: from [10.64.24.57] ([69.53.236.236]) by mx.google.com with ESMTPSA id bs4sm10272718pbc.3.2015.04.17.06.54.03 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 17 Apr 2015 06:54:03 -0700 (PDT) Sender: Warner Losh Subject: Re: Removal of the 6.x kernel compat code from libc Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Content-Type: multipart/signed; boundary="Apple-Mail=_B6C74F8F-736C-473D-ADC9-A0E20AA9535B"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b6 From: Warner Losh In-Reply-To: <3447437.tTGu6eNHtf@ralph.baldwin.cx> Date: Fri, 17 Apr 2015 07:54:01 -0600 Cc: freebsd-arch@freebsd.org, peter@freebsd.org, Konstantin Belousov Message-Id: References: <20150417075942.GI2390@kib.kiev.ua> <3447437.tTGu6eNHtf@ralph.baldwin.cx> To: John Baldwin X-Mailer: Apple Mail (2.2098) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2015 13:54:11 -0000 --Apple-Mail=_B6C74F8F-736C-473D-ADC9-A0E20AA9535B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Apr 17, 2015, at 7:29 AM, John Baldwin wrote: >=20 > On Friday, April 17, 2015 10:59:42 AM Konstantin Belousov wrote: >> Our libc changes in sync with the kernel, but switching of libc to = use >> new interfaces means that upgrade of the userspace becomes the flag = day. >> People usually add backward-compatible shims for libc to use older >> interfaces on old kernels. >>=20 >> There is no reason to keep the compat shims after many years of the >> transition. Patch below purges the compat code for pre-r171219, = which >> added pad-less versions of syscalls taking off_t, and for r177911, = which >> handles the struct flock/oflock transition. This is 6.x/7.x compat, >> we absolutely not support running HEAD libc on such old kernels. >=20 > I think this is fine. I do too. Please look at removing MK_COMPAT_SYSCALLS from the build too, since it was the only knob that controlled these. I don=E2=80=99t see that in = your patch (though it would be easier for me to comment on in phabricator). Also, in lib/libc/sys/fcnt.c: + * Copyright (c) 2014, 2015 The FreeBSD Foundation. Should be 2014-2015 Warner --Apple-Mail=_B6C74F8F-736C-473D-ADC9-A0E20AA9535B Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVMRB5AAoJEGwc0Sh9sBEAJtMQALwot43hq+keyxlp3PAxUyXJ 0e7SqAUAyli/3AJ5xbXPkXu8js8BQjpIwI04KbXUsDvd7h8Mahv5+e9yK/xJz11T 68BR6xBJLXbiPVgNoCrNIChe/JaXqnhsllfW83VUSpoZi45aQnjmFDp4v9PBPO8c qjq/ioRQ8TH++37CXmxBCumaKNtUP1y3iqsJLGnifyp/STWpg43gbkcbIUmclZMd mzjN8uNxVPP9LxvxCdVpxPISDKfcT8aiKtv30K2CZ92IE1Me7u+yVgssjwZ2X25U ij2jVX3nHsHr9VseW+EMEhor51uD+SlsJxk8bJNRwxyo0UHcboc1AXaIofkcwuJY ZkTTZEHxM/T+/EgQUGOcWaGHZs9qbmumIY++rl2hpHqmCT4vhU+qBFbVAIjIxTaG wH+Vsr/YQCRqJao4k64yTcQo3sAHOzoJ52Wffe7XR0TXQ/CgZok/iubDacwkSPoO uobgDLxNbiGFkd7vT2Hsqk7oaSA6XmToHOm8+GL8aVxWKPs0iYfDeVldVxTr1tOI LEugpCFR6MmIIqywSXoXgsMuRj3uysRLiCME4weSh8FYRanz1v5fwOcG937TZT4R bU1IHL+Q8MOaD4ZrE7PTJ3ScrhSnVmxeNzCQY49FWIRuMnDf5D0ne1j6ObItApNU jH2QHstyMpn8O/yDD3ue =t+KZ -----END PGP SIGNATURE----- --Apple-Mail=_B6C74F8F-736C-473D-ADC9-A0E20AA9535B--