From nobody Mon Mar 23 15:08:23 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ffc4S45gjz6W7Gb for ; Mon, 23 Mar 2026 15:08:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ffc4S0J0Jz470m for ; Mon, 23 Mar 2026 15:08:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774278504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mIQqclkVbn1B524fSRkhccvG2Hn8C9S31zHjvvdF05A=; b=gOrxyOvxM3drNMLKQ+CAEWjKPiLRBBI0oWNG00AYsGI0Z5JcgO+cOzRq6/XCG+JNKUGYSd w1dZ6CrRM2NHR5Zmj9E/cS2e95PH9M4Zvq2Oy01yA/Urmcce5glGssr68wjTN1ZlxigPc1 4RWJ5yFc2dGBXE1MVtd50NbIElT3L8RxbOGq67paJhB53u1edVpbnnxDnvkW+h29hV1xwh ETeB3Z2ABI4rgjpRaDIEXi7ETHCaL5GhBwWaTMbPvCvFBddZRb/gdrI5hR4Ue3HYjhki/z VsshH6IeDwUVqhASIpF4rCEcGBTsWDYcN2LMCYfLJTq3dstRHr81XPcRouWBBA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774278504; a=rsa-sha256; cv=none; b=FV2IOQXoeUVfFsrBEtLhxasGprwrQTpX7Ssg0FWHvzILP4LCBUjl3FtlQ7dUqkOhjd7UoB Yk/f5VZ8hGpO0hMcIFysKegF1P5OOCqrSlROuiRwakBXM5PY8l2oVjmOcOCFIVpeKnxZbR RGVFqmzvBSi+v7Uyu1fMqvvlMlkA+gB1154X2mwq9UBGK8pggwC8eYiHCB/j6XoiTvYiXF dSZ8rDv2rS/u3i5yokT5VOQ1K7VC3FvD+jvFiYDIbmnUfqCLSFShkBwuOfu8hRBwvz2VX+ G2ps+k93WFV0pmOB3vpgoHeUie3p6mseRKwxU9V1sYAAkYI/8VSyYHiibmkf3Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774278504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mIQqclkVbn1B524fSRkhccvG2Hn8C9S31zHjvvdF05A=; b=mVbcEBn7Si+1yqr6edgsAWtpTIzNTo0TnyfueD3ylqatvesgPZugyEx7K1ZjZCXsR2Qy0o PmgHcD0NEWP/fcOHsh56fNhzTTMjFESPfEZqM3j5iH4rb1MO/s5JUVMKxhJe3cCr80d/XR pPzB/OHY1g+SpenBH6g51joNrZAzY0pRQG+Yn17/w0304B8yrFdhPa6vIjkcEUW8TDqGV3 gtSpbLyhaVYGgbvnbeivMWpBXzA/f9zCDWui7FAgm0d6tVSekU25w2cyh2p6zGFd9PnUuy zc0OHSRsbpRPEfB1Ol4JBaQhNnZd16ARK7VJS983VuDQ7REYaJBIJMCaDrAuBA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4ffc4R56N8zsC9 for ; Mon, 23 Mar 2026 15:08:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 20faa by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 23 Mar 2026 15:08:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 47caac85ec51 - stable/15 - queue.h: Reorder STAILQ_INSERT_TAIL List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 47caac85ec51e2f3fefc976a5e110f444693b657 Auto-Submitted: auto-generated Date: Mon, 23 Mar 2026 15:08:23 +0000 Message-Id: <69c15767.20faa.56367333@gitrepo.freebsd.org> The branch stable/15 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=47caac85ec51e2f3fefc976a5e110f444693b657 commit 47caac85ec51e2f3fefc976a5e110f444693b657 Author: Dag-Erling Smørgrav AuthorDate: 2026-03-16 20:36:56 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-03-22 17:32:41 +0000 queue.h: Reorder STAILQ_INSERT_TAIL The current implementation briefly violates the tail invariant. This is not usually an issue, but if an insert is in flight when a panic occurs, we may then trip the invariant while dumping core. MFC after: 1 week Sponsored by: Klara, Inc. Sponsored by: NetApp, Inc. Reviewed by: obiwac, olce, jhb Differential Revision: https://reviews.freebsd.org/D55819 (cherry picked from commit aa15df4597053c0e95a15b2a7036296999cd562a) --- sys/sys/queue.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/sys/queue.h b/sys/sys/queue.h index aa6453889e6b..e2603bc664c3 100644 --- a/sys/sys/queue.h +++ b/sys/sys/queue.h @@ -499,9 +499,10 @@ struct { \ #define STAILQ_INSERT_TAIL(head, elm, field) do { \ QMD_STAILQ_CHECK_TAIL(head); \ + __typeof__((head)->stqh_last) prevlast = (head)->stqh_last; \ STAILQ_NEXT((elm), field) = NULL; \ - *(head)->stqh_last = (elm); \ (head)->stqh_last = &STAILQ_NEXT((elm), field); \ + *prevlast = (elm); \ } while (0) #define STAILQ_LAST(head, type, field) \