Date: Fri, 25 Apr 2008 22:36:47 +0900 From: Daichi GOTO <daichi@freebsd.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Masanori OZAWA <ozawa@ongs.co.jp>, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/unionfs union_subr.c Message-ID: <4811DE6F.9040604@freebsd.org> In-Reply-To: <20080425131229.C80552@fledge.watson.org> References: <200804250953.m3P9rrpd011741@repoman.freebsd.org> <20080425131229.C80552@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi rwatson, thanks for your response :) Robert Watson wrote: > On Fri, 25 Apr 2008, Daichi GOTO wrote: > >> daichi 2008-04-25 09:53:52 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/fs/unionfs union_subr.c >> Log: >> o Improved unix socket connection issue >> fixed: kern/118346 >> >> PR: kern/118346 >> Submitted by: Masanori OZAWA (ozawa@ongs.co.jp) >> MFC after: 1 week > > Goto-san, > > Per my earlier e-mail, and assuming I understand correctly, I feel not > only will this lead to new panics (due to dangling socket pointers and > incomplete garbage collection), We, I and ozawa-san, cannot image the case that leads new panic. Would you tell us how to get the panic if you can get it? Is it rare case to get or not? > but it will also lead to possibly > incorrect semantics for unionfs (upper layers can write to objects > readable via the lower layer). > Some parts of this patch are fine, but > the copying of v_socket pointers between layers is not correct. Please > consider backing that part of the change out. Yes, we have noticed above. But.... at least, our patch solves problem of http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/118346 we believe. If I roll back that, that problem is still there. Uhmmm... is it better to get back it? And if you have some ideas to solve this issue, please tell us :) Thanks > Thanks, > > Robert N M Watson > Computer Laboratory > University of Cambridge -- Daichi GOTO, http://people.freebsd.org/~daichi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4811DE6F.9040604>