From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Sep 14 18:00:45 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E8DC216A415 for ; Thu, 14 Sep 2006 18:00:44 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 262D343D5A for ; Thu, 14 Sep 2006 18:00:39 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k8EI0cKO057601 for ; Thu, 14 Sep 2006 18:00:38 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k8EI0cFo057600; Thu, 14 Sep 2006 18:00:38 GMT (envelope-from gnats) Resent-Date: Thu, 14 Sep 2006 18:00:38 GMT Resent-Message-Id: <200609141800.k8EI0cFo057600@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Scot Hetzel Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E25C16A416 for ; Thu, 14 Sep 2006 17:53:00 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id EBD1F43DB4 for ; Thu, 14 Sep 2006 17:52:59 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k8EHqxmX047194 for ; Thu, 14 Sep 2006 17:52:59 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id k8EHqwCC047180; Thu, 14 Sep 2006 17:52:59 GMT (envelope-from nobody) Message-Id: <200609141752.k8EHqwCC047180@www.freebsd.org> Date: Thu, 14 Sep 2006 17:52:59 GMT From: Scot Hetzel To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: ports/103276: net/samba3: Add a notice when FAM_SUPPORT is being forced. X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2006 18:00:45 -0000 >Number: 103276 >Category: ports >Synopsis: net/samba3: Add a notice when FAM_SUPPORT is being forced. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Sep 14 18:00:38 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Scot Hetzel >Release: 6.1-STABLE >Organization: Ye Old Computer >Environment: >Description: When you have either fam/gamin installed, and then build the net/samba3 but don't select FAM_SUPPORT from the OPTIONS menu, the port builds with FAM_SUPPORT anyways. The reason for this is that the Samba3 configure script automatically detectes the fam/gamin library and enables support for FAM. The configure script doesn't have an option to disable this behavior. >How-To-Repeat: On a system without fam/gamin installed run: make -V LIB_DEPENDS then install either fam/gamin and run: make -V LIB_DEPENDS You'll see that FAM has been added to the list of LIB_DEPENDS. >Fix: Add a notice in pre-everything advising that FAM_SUPPORT has been forced. Index: Makefile =================================================================== RCS file: /home/ncvs/ports/net/samba3/Makefile,v retrieving revision 1.152 diff -u -r1.152 Makefile --- Makefile 4 Sep 2006 19:00:17 -0000 1.152 +++ Makefile 14 Sep 2006 17:22:20 -0000 @@ -299,6 +299,10 @@ SAMBA_PRIVATE=${SAMBA_PRIVATE} pre-everything:: +.if defined(WANT_FAM_SYSTEM) + @${ECHO_CMD} "===> NOTICE: ${WANT_FAM_SYSTEM} detected, forcing FAM_SUPPORT" + @${ECHO_CMD} "" +.endif @${ECHO_CMD} "===> NOTICE: This version of port has changed location of Samba password" @${ECHO_CMD} "===> NOTICE: (smbpasswd) directory. Files in '${SAMBA_PRIVATE}'" @${ECHO_CMD} "===> NOTICE: have moved to '${SAMBA_PRIVATEDIR}'." >Release-Note: >Audit-Trail: >Unformatted: