From owner-svn-src-head@freebsd.org Sat Apr 20 22:31:56 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 404D91577BFF for ; Sat, 20 Apr 2019 22:31:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D4AE574C0A for ; Sat, 20 Apr 2019 22:31:55 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x743.google.com with SMTP id w20so4640444qka.7 for ; Sat, 20 Apr 2019 15:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1eRTts1CX+1nCVPz573K1PJVtZD+6kzsIl94YWGYO3U=; b=Vt2LhWaNGXtjn/m4tqnVkF1hAaAR6jlpqwO8yQewV7Ys1JD221Zk7RPFSP/18EnLuo CfXWeolrU1TRhAZ6PoQ3e11pDbjm4QrClIZK70ArsjfZGTkL6DqhGKKYOlB/FNgwMlWL o6tJmFUuxwYGHI5VoXfxhDVjUWDhzbupx9c4rou5/H6UpQZakQAJhSAwUcNOJXb53SAk MQuqowBRCXs6RWQWzYZBqvnjVtiCqWI5Z9o3T+KqYAbFDKQ7p1DxUQfR+RL2uUNYPnT+ Js5R4nEdteVCS4TYdhhg4Pt4PGEbCyCY5PFdyjdBPiD6QQX8T8kUdu33KYTPDHzmfzm9 v6Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1eRTts1CX+1nCVPz573K1PJVtZD+6kzsIl94YWGYO3U=; b=pUr8IeiV15OldML6EC9P14ZZE2+YPqtlEJTuIQOUjWH95ltmz2ZkpeoJsNXsc9QA2e Y19N6rV3nRISWt+9/5HsMhiTiiYW1Pxk3KL+Sr6x+bxF7ayLi68GwCu7A99mtja7xJkD FkC7hRfE4SxnsszdM05iWUimCxK/0+goAv/16SnoNOmntpZVHOAQKWwilFQEP6Pvac6O jbYFV0yobXHL5bMSsyVwoEqQIIgKsd9tbOIouzhpDtjGgOsZQ/uhLXK3lxNUfAgltLau iiHStIM1sr8Ps8Z6AX9TsP0Ymsf4DYxgehsE6Q4GLyXJuVoMQEQswBXWaXpqAgvvR35O d8WQ== X-Gm-Message-State: APjAAAUhU2+WsicONge5I0hk6j9O87crPbm6KqN6DpCg1EKDGdB/n9Gp X3M/swG2kT2qB6tGO7icmFtGydiGJh2f22IeQsPo9g== X-Google-Smtp-Source: APXvYqz17YYgFRB00jAEQbNcCdOGcAqOBpXd+8kLURMKAJvRmTEOy2vPOnTrn8y7Waysn0DhEPjc2YkL68XrZj/TCN4= X-Received: by 2002:ae9:ee0c:: with SMTP id i12mr6954404qkg.46.1555799514909; Sat, 20 Apr 2019 15:31:54 -0700 (PDT) MIME-Version: 1.0 References: <201904201251.x3KCp6it044898@repo.freebsd.org> <5bf4a702-7df8-5597-25b0-55baa71d1d4f@FreeBSD.org> In-Reply-To: From: Warner Losh Date: Sat, 20 Apr 2019 16:31:43 -0600 Message-ID: Subject: Re: svn commit: r346441 - in head/sys/modules: em fusefs iavf To: John Baldwin Cc: Justin Hibbits , Alan Somers , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: D4AE574C0A X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.91 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.91)[-0.909,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Apr 2019 22:31:56 -0000 On Sat, Apr 20, 2019 at 2:03 PM John Baldwin wrote: > On 4/20/19 10:21 AM, Warner Losh wrote: > > On Sat, Apr 20, 2019, 10:44 AM John Baldwin wrote: > > > >> On 4/20/19 6:23 AM, Justin Hibbits wrote: > >>> On Sat, Apr 20, 2019, 08:21 Alan Somers wrote: > >>> > >>>> On Sat, Apr 20, 2019 at 6:58 AM Justin Hibbits > >>>> wrote: > >>>>> > >>>>> > >>>>> > >>>>> On Sat, Apr 20, 2019, 07:51 Alan Somers wrote: > >>>>>> > >>>>>> Author: asomers > >>>>>> Date: Sat Apr 20 12:51:05 2019 > >>>>>> New Revision: 346441 > >>>>>> URL: https://svnweb.freebsd.org/changeset/base/346441 > >>>>>> > >>>>>> Log: > >>>>>> Use symlinks for kernel modules rather than hardlinks > >>>>>> > >>>>>> When aliasing a kernel module to a different name (ie if_igb for > >>>> if_em), > >>>>>> it's better to use symlinks than hard links. kldxref will omit > >>>> entries for > >>>>>> the links, ensuring that the loaded module has the correct name. > >>>>>> > >>>>>> > >>>>> > >>>>> > >>>>> Thanks! This should fix installkernel on my POWER9. > >>>>> > >>>>> - Justin > >>>> > >>>> What's the problem with your POWER9? Is that one of those msdosfs > >>>> /boot systems? If so, I don't think this will fix it. msdosfs > >>>> doesn't support either symlinks or hardlinks. Or is there some other > >>>> problem? > >>>> -Alan > >>>> > >>> > >>> Yes it is. Well that's a bummer then. I thought we faked symlinks on > >>> msdosfs, but on second thought not sure how well would do that. > >> > >> You could just use cp instead of a link? > >> > > > > I don't think this solves the original issue. > > FWIW, I think igb and em still use separate driver_t's with separate > probe tables, etc. to preserve POLA of existing device names, so in > theory there could still be two modules, it's just by choice that they > are both in the same C file and same kld. > Yea, I sometimes wish they'd have if_em.ko that's just this table and a dependency to igb.ko plus another if_igb.ko with the same dependency. That would be cleaner than the hacky thing we're doing which forces us to have other hacks in kldload, etc. Warner