From owner-svn-src-all@FreeBSD.ORG Sat Oct 8 19:50:01 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B43F6106566B; Sat, 8 Oct 2011 19:50:01 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) by mx1.freebsd.org (Postfix) with ESMTP id 906F98FC08; Sat, 8 Oct 2011 19:50:01 +0000 (UTC) Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.14.5/8.14.5) with ESMTP id p98Jo1lX077469; Sat, 8 Oct 2011 12:50:01 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.14.5/8.14.5/Submit) id p98Jo1Mg077468; Sat, 8 Oct 2011 12:50:01 -0700 (PDT) (envelope-from sgk) Date: Sat, 8 Oct 2011 12:50:01 -0700 From: Steve Kargl To: Doug Barton Message-ID: <20111008195001.GA77379@troutmask.apl.washington.edu> References: <201110081825.p98IP22D073560@svn.freebsd.org> <4E90A5D4.9020006@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E90A5D4.9020006@FreeBSD.org> User-Agent: Mutt/1.4.2.3i Cc: Chris Rees , svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r226162 - head/share/mk X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Oct 2011 19:50:01 -0000 On Sat, Oct 08, 2011 at 12:34:44PM -0700, Doug Barton wrote: > On 10/08/2011 11:25, Chris Rees wrote: > > Author: crees (ports committer) > > Date: Sat Oct 8 18:25:01 2011 > > New Revision: 226162 > > URL: http://svn.freebsd.org/changeset/base/226162 > > > > Log: > > Revert unapproved commit to bsd.port.mk. > > This is completely unacceptable. We don't do "commit wars" in FreeBSD. FWIW, I completely agree with Doug, which is a rare event. The original commit message included This commit should be reverted when there is a cleaner fix in autotools and/or ports/Mk/bsd.port.mk. Chris, it appears that you did not commit a cleaner fix. You also seem to have omitted the "Approved by", "Reviewed by", and/or "Discussed on" line in your commit message. -- Steve