Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 8 Oct 2011 12:50:01 -0700
From:      Steve Kargl <sgk@troutmask.apl.washington.edu>
To:        Doug Barton <dougb@FreeBSD.org>
Cc:        Chris Rees <crees@FreeBSD.org>, svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r226162 - head/share/mk
Message-ID:  <20111008195001.GA77379@troutmask.apl.washington.edu>
In-Reply-To: <4E90A5D4.9020006@FreeBSD.org>
References:  <201110081825.p98IP22D073560@svn.freebsd.org> <4E90A5D4.9020006@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 08, 2011 at 12:34:44PM -0700, Doug Barton wrote:
> On 10/08/2011 11:25, Chris Rees wrote:
> > Author: crees (ports committer)
> > Date: Sat Oct  8 18:25:01 2011
> > New Revision: 226162
> > URL: http://svn.freebsd.org/changeset/base/226162
> > 
> > Log:
> >   Revert unapproved commit to bsd.port.mk.
> 
> This is completely unacceptable. We don't do "commit wars" in FreeBSD.

FWIW, I completely agree with Doug, which is a rare event.
The original commit message included

   This commit should be reverted when there is a cleaner fix
   in autotools and/or ports/Mk/bsd.port.mk.

Chris, it appears that you did not commit a cleaner fix.
You also seem to have omitted the "Approved by", "Reviewed by",
and/or "Discussed on" line in your commit message.

-- 
Steve



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111008195001.GA77379>