From owner-dev-commits-src-main@freebsd.org Sat Jan 30 18:04:13 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 313154F47D9; Sat, 30 Jan 2021 18:04:13 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DSht50lpmz4sFM; Sat, 30 Jan 2021 18:04:13 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:13b:39f::9f:25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id E4EF129C1F; Sat, 30 Jan 2021 18:04:12 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 0A04E8D4A323; Sat, 30 Jan 2021 18:04:11 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 39A04E707CB; Sat, 30 Jan 2021 18:04:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id pIwzsjBqhBU2; Sat, 30 Jan 2021 18:04:09 +0000 (UTC) Received: from [127.0.0.1] (unknown [IPv6:fde9:577b:c1a9:4902:ddc0:5fd7:79e3:c774]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id E3DF2E707C2; Sat, 30 Jan 2021 18:04:08 +0000 (UTC) From: "Bjoern A. Zeeb" To: "=?utf-8?q?T=C4=B3l?= Coosemans" Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: a6c2507d1bae - main - LinuxKPI: add firmware loading support Date: Sat, 30 Jan 2021 18:04:08 +0000 X-Mailer: MailMate (2.0BETAr6151) Message-ID: <1EC4140C-506F-4F10-89B6-293340D07BA9@FreeBSD.org> In-Reply-To: <20210130170206.76e1319a@FreeBSD.org> References: <202101281645.10SGjwmh088797@gitrepo.freebsd.org> <20210130170206.76e1319a@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jan 2021 18:04:13 -0000 On 30 Jan 2021, at 16:02, T=C4=B3l Coosemans wrote: > On Thu, 28 Jan 2021 16:45:58 GMT "Bjoern A. Zeeb" = > wrote: >> The branch main has been updated by bz: >> >> URL: = >> https://cgit.FreeBSD.org/src/commit/?id=3Da6c2507d1baedb183268e31bc6b6= f659a9529904 >> >> commit a6c2507d1baedb183268e31bc6b6f659a9529904 >> Author: Bjoern A. Zeeb >> AuthorDate: 2021-01-28 16:05:32 +0000 >> Commit: Bjoern A. Zeeb >> CommitDate: 2021-01-28 16:05:32 +0000 >> >> LinuxKPI: add firmware loading support > > The module fails to load now because it can't find firmware_get_flags. > You need to add MODULE_DEPEND(linuxkpi, firmware, 1, 1, 1) in > linux_kmod.c Done in 4a26380ba6dc487a7525d909ee29fbc710b558d1. Thanks a lot for reporting! /bz